* [PATCH 0/7] dead code elimination
@ 2019-10-21 11:22 7% Eric Wong
2019-10-21 11:22 6% ` [PATCH 2/7] www: remove unused ctx_get sub Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-10-21 11:22 UTC (permalink / raw)
To: meta
I noticed OverIdx->delete_articles was unused while
working on the --reindex bug with multiple Message-IDs,
and went looking for more dead code.
This should make release tarballs smaller, at least.
Eric Wong (7):
overidx: remove unused delete_articles sub
www: remove unused ctx_get sub
inboxwritable: import_maildir uses maildir_path_load
watchmaildir: remove redundant _path_to_mime
git: remove src_blob_url
hval: remove new_oneline
syscall: get rid of sendfile wrappers for now
lib/PublicInbox/Git.pm | 11 -----
lib/PublicInbox/Hval.pm | 8 ----
lib/PublicInbox/InboxWritable.pm | 2 +-
lib/PublicInbox/OverIdx.pm | 6 ---
lib/PublicInbox/Syscall.pm | 75 +-------------------------------
lib/PublicInbox/WWW.pm | 7 ---
lib/PublicInbox/WatchMaildir.pm | 20 ++-------
7 files changed, 5 insertions(+), 124 deletions(-)
^ permalink raw reply [relevance 7%]
* [PATCH 2/7] www: remove unused ctx_get sub
2019-10-21 11:22 7% [PATCH 0/7] dead code elimination Eric Wong
@ 2019-10-21 11:22 6% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-10-21 11:22 UTC (permalink / raw)
To: meta
This hasn't been used since commit 48b21cb662c1e17b7 in 2016:
("declare Inbox object for reusability")
---
lib/PublicInbox/WWW.pm | 7 -------
1 file changed, 7 deletions(-)
diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index d0b9f387..4b7177c1 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -300,13 +300,6 @@ sub get_vcs_object ($$$;$) {
PublicInbox::ViewVCS::show($ctx, $oid, $filename);
}
-sub ctx_get {
- my ($ctx, $key) = @_;
- my $val = $ctx->{$key};
- (defined $val && $val ne '') or die "BUG: bad ctx, $key unusable";
- $val;
-}
-
sub need {
my ($ctx, $extra) = @_;
my $msg = <<EOF;
^ permalink raw reply related [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-10-21 11:22 7% [PATCH 0/7] dead code elimination Eric Wong
2019-10-21 11:22 6% ` [PATCH 2/7] www: remove unused ctx_get sub Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).