* Re: [PATCH] www: more consistent URL generation line
@ 2016-04-02 23:20 4% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-04-02 23:20 UTC (permalink / raw)
To: meta
Rejected in favor of
http://public-inbox.org/meta/20160402223213.8293-1-e@80x24.org/
('www: more explicit "git clone" usage')
^ permalink raw reply [relevance 4%]
* [PATCH] www: more explicit "git clone" usage
@ 2016-04-02 22:32 7% Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-04-02 22:32 UTC (permalink / raw)
To: meta
Little harm in having the entire command-line for users and
avoiding the cognitive overhead of figuring out $URL.
---
lib/PublicInbox/WWW.pm | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index 369be68..bb54aaa 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -277,12 +277,11 @@ sub footer {
my $ssoma_url = PublicInbox::Hval::prurl($cgi->{env}, SSOMA_URL);
if (scalar(@urls) == 1) {
$urls = "URL for <a\nhref=\"" . $ssoma_url .
- qq(">ssoma</a> or <b>git clone --mirror \$URL</b> :) .
- $urls[0];
+ qq(">ssoma</a> or <b>git clone --mirror $urls[0]</b>);
} else {
$urls = "URLs for <a\nhref=\"" . $ssoma_url .
- qq(">ssoma</a> or <b>git clone --mirror \$URL</b>\n) .
- join("\n", map { "\t$_" } @urls);
+ qq(">ssoma</a> or <b>git clone --mirror</b>\n) .
+ join("\n", map { "\tgit clone --mirror $_" } @urls);
}
my $addr = $ctx->{pi_config}->get($listname, 'address');
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-03-17 23:06 [PATCH] www: more consistent URL generation line Eric Wong
2016-04-02 23:20 4% ` Eric Wong
2016-04-02 22:32 7% [PATCH] www: more explicit "git clone" usage Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).