* [PATCH 1/2] www: label sections and hopefully improve navigation
2016-07-21 1:23 6% [PATCH 0/2] www: navigation improvements (hopefully) Eric Wong
@ 2016-07-21 1:23 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-07-21 1:23 UTC (permalink / raw)
To: meta
Clearly label "Thread overview" and "Reply instructions"
so users can quickly skip stuff they're not interested in.
Additionally, note the fact the thread view allows quick
navigation within the thread to avoid extra network requests
and improve the display for single-message threads.
Finally, use <hr> to better-delineate sections of each page.
---
lib/PublicInbox/View.pm | 19 ++++++++++++-------
lib/PublicInbox/WwwStream.pm | 2 +-
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 4906864..5f99644 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -61,10 +61,12 @@ sub msg_reply {
push @$arg, '/path/to/YOUR_REPLY';
$arg = join(" \\\n ", '', @$arg);
<<EOF
-<pre
-id=R>You may reply publically to <a
-href=#t>this message</a> via
-plain-text email using any one of the following methods:
+<hr><pre
+id=R><b>Reply instructions:</b>
+
+You may reply publically to <a
+href=#t>this message</a> via plain-text email
+using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: <a
@@ -326,10 +328,12 @@ sub thread_html {
return missing_thread($ctx) if $nr == 0;
my $skel = '<hr><pre>';
$skel .= $nr == 1 ? 'only message in thread' : 'end of thread';
- $skel .= ", back to <a\nhref=\"../../\">index</a>";
- $skel .= "\n<a\nid=t>$nr+ messages in thread:</a> (download: ";
- $skel .= "<a\nhref=\"../t.mbox.gz\">mbox.gz</a>";
+ $skel .= ", back to <a\nhref=\"../../\">index</a>\n\n";
+ $skel .= "<b\nid=t>Thread overview:</b> ";
+ $skel .= $nr == 1 ? '(only message)' : "$nr+ messages";
+ $skel .= " (download: <a\nhref=\"../t.mbox.gz\">mbox.gz</a>";
$skel .= " / follow: <a\nhref=\"../t.atom\">Atom feed</a>)\n";
+ $skel .= "-- links below jump to the message on this page --\n";
$ctx->{-upfx} = '../../';
$ctx->{cur_level} = 0;
$ctx->{dst} = \$skel;
@@ -523,6 +527,7 @@ sub thread_skel {
qq(/ <a\nhref="${tpfx}t.atom">Atom feed</a>);
my $parent = in_reply_to($hdr);
+ $$dst .= "\n<b>Thread overview: </b>";
if ($nr <= 1) {
if (defined $parent) {
$$dst .= "($expand)\n ";
diff --git a/lib/PublicInbox/WwwStream.pm b/lib/PublicInbox/WwwStream.pm
index bce384b..bdc8048 100644
--- a/lib/PublicInbox/WwwStream.pm
+++ b/lib/PublicInbox/WwwStream.pm
@@ -80,7 +80,7 @@ sub _html_end {
join("\n", map { "\tgit clone --mirror $_" } @urls);
}
my $url = PublicInbox::Hval::prurl($ctx->{env}, PI_URL);
- '<pre>'.join("\n",
+ '<hr><pre>'.join("\n",
'- ' . $desc,
$urls,
'Served with public-inbox: '.
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] www: navigation improvements (hopefully)
@ 2016-07-21 1:23 6% Eric Wong
2016-07-21 1:23 7% ` [PATCH 1/2] www: label sections and hopefully improve navigation Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-07-21 1:23 UTC (permalink / raw)
To: meta
1/2 is purely subjective; 2/2 improves compatibility for
users of older git.
Eric Wong (2):
www: label sections and hopefully improve navigation
view: split up --cc args for git-send-email
lib/PublicInbox/View.pm | 31 ++++++++++++++++++-------------
lib/PublicInbox/WwwStream.pm | 2 +-
2 files changed, 19 insertions(+), 14 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-07-21 1:23 6% [PATCH 0/2] www: navigation improvements (hopefully) Eric Wong
2016-07-21 1:23 7% ` [PATCH 1/2] www: label sections and hopefully improve navigation Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).