* [PATCH 3/4] viewvcs: load blobs asynchronously
2022-09-26 10:17 6% [PATCH 0/4] some minor performance tweaks Eric Wong
@ 2022-09-26 10:17 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2022-09-26 10:17 UTC (permalink / raw)
To: meta
This actually leads to a nice 3-5% speedup under parallel loads
when using git(1) w/o SHA-1 collision detection enabled. Gcf2
is slower since libgit2 has SHA-1 collision detection enabled
on my system.
Since we're in the area, improve location of comments w.r.t.
cgit CSS class names and note the reliance on scratchpad for
performance in a tight loop.
---
lib/PublicInbox/ViewVCS.pm | 21 ++++++++++++++++-----
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index f740591d..915cf2c5 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -413,11 +413,21 @@ sub solve_result {
blob $oid $size bytes $raw_link</pre>
EOM
}
+ @{$ctx->{-paths}} = ($path, $raw_link);
+ $ctx->{git} = $git;
+ if ($ctx->{env}->{'pi-httpd.async'}) {
+ ibx_async_cat($ctx, $oid, \&show_blob, $ctx);
+ } else { # synchronous
+ $git->cat_async($oid, \&show_blob, $ctx);
+ $git->cat_async_wait;
+ }
+}
- my $blob = $git->cat_file($oid);
- if (!$blob) { # WTF?
+sub show_blob { # git->cat_async callback
+ my ($blob, $oid, $type, $size, $ctx) = @_;
+ if (!$blob) {
my $e = "Failed to retrieve generated blob ($oid)";
- warn "$e ($git->{git_dir})";
+ warn "$e ($ctx->{git}->{git_dir}) type=$type";
return html_page($ctx, 500, "<pre><b>$e</b></pre>".dbg_log($ctx))
}
@@ -428,6 +438,7 @@ EOM
return delete($ctx->{-wcb})->([200, $h, [ $$blob ]]);
}
+ my ($path, $raw_link) = @{delete $ctx->{-paths}};
$bin and return html_page($ctx, 200,
"<pre>blob $oid $size bytes (binary)" .
" $raw_link</pre>".dbg_log($ctx));
@@ -445,14 +456,14 @@ EOM
$$blob = ascii_html($$blob);
}
+ # using some of the same CSS class names and ids as cgit
my $x = "<pre>blob $oid $size bytes $raw_link</pre>" .
"<hr /><table\nclass=blob>".
"<tr><td\nclass=linenumbers><pre>";
+ # scratchpad in this loop is faster here than `printf $zfh':
$x .= sprintf("<a id=n$_ href=#n$_>% ${pad}u</a>\n", $_) for (1..$nl);
$x .= '</pre></td><td><pre> </pre></td>'. # pad for non-CSS users
"<td\nclass=lines><pre\nstyle='white-space:pre'><code>";
-
- # using some of the same CSS class names and ids as cgit
html_page($ctx, 200, $x, $ctx->{-linkify}->linkify_2($$blob),
'</code></pre></td></tr></table>'.dbg_log($ctx));
}
^ permalink raw reply related [relevance 7%]
* [PATCH 0/4] some minor performance tweaks
@ 2022-09-26 10:17 6% Eric Wong
2022-09-26 10:17 7% ` [PATCH 3/4] viewvcs: load blobs asynchronously Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2022-09-26 10:17 UTC (permalink / raw)
To: meta
There's some weird stuff cooking up that's not ready, yet...
Here's a few minor tweaks which should provide benefits today,
though.
1/4 should be the last major-ish memory reduction in WWW for a
while. 2/4 is needed for 3/4 with libgit2, and 4/4 may prove
more useful in the future...
Eric Wong (4):
viewdiff: save memory by eliminating two captures
gcf2: support worktree $GIT_DIR
viewvcs: load blobs asynchronously
git: reduce early bare-bones memory use
lib/PublicInbox/Gcf2.pm | 7 ++++---
lib/PublicInbox/Git.pm | 4 ++--
lib/PublicInbox/ViewDiff.pm | 18 +++++++++---------
lib/PublicInbox/ViewVCS.pm | 21 ++++++++++++++++-----
4 files changed, 31 insertions(+), 19 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2022-09-26 10:17 6% [PATCH 0/4] some minor performance tweaks Eric Wong
2022-09-26 10:17 7% ` [PATCH 3/4] viewvcs: load blobs asynchronously Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).