* [PATCH 07/11] viewvcs: expand on path names being "non-authoritative"
2023-01-24 9:49 6% [PATCH 00/11] www_coderepo: subjective web stuffs Eric Wong
@ 2023-01-24 9:49 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2023-01-24 9:49 UTC (permalink / raw)
To: meta
Hopefully this makes sense...
---
lib/PublicInbox/ViewVCS.pm | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 60cc1376..0dfe6081 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -509,11 +509,19 @@ sub solve_result {
my $paths = $ctx->{-paths} //= do {
my $path = to_filename($fn // 'blob');
my $raw_more = qq[(<a\nhref="$path">raw</a>)];
+ my @def;
# XXX not sure if this is the correct wording
- defined($fn) and $raw_more .=
-"\nname: ${\ascii_html($fn)} \t # note: path name is non-authoritative";
- [ $path, $raw_more ];
+ if (defined($fn)) {
+ $raw_more .= qq(
+name: ${\ascii_html($fn)} \t # note: path name is non-authoritative<a
+href="#pathdef" id=top>(*)</a>);
+ $def[0] = "<hr><pre\nid=pathdef>" .
+'(*) Git path names are given by the tree(s) the blob belongs to.
+ Blobs themselves have no identifier aside from the hash of its contents.'.
+qq(<a\nhref="#top">^</a></pre>);
+ }
+ [ $path, $raw_more, @def ];
};
$ctx->{-q_value_html} //= do {
my $s = defined($fn) ? 'dfn:'.ascii_html($fn).' ' : '';
@@ -547,7 +555,7 @@ sub show_blob { # git->cat_async callback
return delete($ctx->{-wcb})->([200, $h, [ $$blob ]]);
}
- my ($path, $raw_more) = @{delete $ctx->{-paths}};
+ my ($path, $raw_more, @def) = @{delete $ctx->{-paths}};
$bin and return html_page($ctx, 200,
"<pre>blob $oid $size bytes (binary)" .
" $raw_more</pre>".dbg_log($ctx));
@@ -574,7 +582,7 @@ sub show_blob { # git->cat_async callback
$x .= '</pre></td><td><pre> </pre></td>'. # pad for non-CSS users
"<td\nclass=lines><pre\nstyle='white-space:pre'><code>";
html_page($ctx, 200, $x, $ctx->{-linkify}->linkify_2($$blob),
- '</code></pre></td></tr></table>'.dbg_log($ctx));
+ '</code></pre></td></tr></table>'.dbg_log($ctx), @def);
}
# GET /$INBOX/$GIT_OBJECT_ID/s/
^ permalink raw reply related [relevance 7%]
* [PATCH 00/11] www_coderepo: subjective web stuffs
@ 2023-01-24 9:49 6% Eric Wong
2023-01-24 9:49 7% ` [PATCH 07/11] viewvcs: expand on path names being "non-authoritative" Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-01-24 9:49 UTC (permalink / raw)
To: meta
Aside from avoiding FD waste for /dev/null in common
deployments, there's not much _measurably_ better.
Eric Wong (11):
qspawn: drop lineno from command failure warning
viewvcs: add path name hint based on `b=' query param
viewvcs: prepopulate search bar with dfpost + dfn
www_coderepo: show /$INBOX/?t=$DATE link for commits
www_coderepo: eliminate debug log footer
http: reuse STDIN if it's already /dev/null
viewvcs: expand on path names being "non-authoritative"
viewvcs: show message for 404||500 errors
solver_git: remove extraneous leading `-'
www_coderepo: remove some needless return statements
viewvcs: improve tree glossary view
lib/PublicInbox/HTTP.pm | 8 ++++-
lib/PublicInbox/Qspawn.pm | 2 +-
lib/PublicInbox/RepoTree.pm | 3 +-
lib/PublicInbox/SolverGit.pm | 2 +-
lib/PublicInbox/ViewVCS.pm | 56 ++++++++++++++++++++++++++--------
lib/PublicInbox/WwwCoderepo.pm | 50 +++++++++++++++---------------
t/solver_git.t | 2 +-
7 files changed, 81 insertions(+), 42 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-01-24 9:49 6% [PATCH 00/11] www_coderepo: subjective web stuffs Eric Wong
2023-01-24 9:49 7% ` [PATCH 07/11] viewvcs: expand on path names being "non-authoritative" Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).