user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH] viewvcs: check for premature EOF from git-cat-file
@ 2019-04-02  0:45  7% Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2019-04-02  0:45 UTC (permalink / raw)
  To: meta

Not entirely sure what is causing this, but it appears to
be causing infinite loops when attempting to display certain
blobs.

Fortunately, the fair scheduling of public-inbox-httpd prevented
this from becoming a real problem aside from increasing CPU
usage.
---
 lib/PublicInbox/ViewVCS.pm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index b90cd8c..962dc66 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -62,6 +62,10 @@ sub stream_large_blob ($$$$) {
 				my $ct = 'text/plain; charset=UTF-8';
 				return [200, ['Content-Type', $ct, @cl] ];
 			}
+			if ($r == 0) {
+				warn "premature EOF on $oid $$logref\n";
+				return html_page($ctx, 500, $logref);
+			}
 			undef; # bref keeps growing
 		}
 	});
-- 
EW


^ permalink raw reply related	[relevance 7%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-04-02  0:45  7% [PATCH] viewvcs: check for premature EOF from git-cat-file Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).