user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 06/11] viewvcs: avoid segfault with highlight.pm at shutdown
  2019-01-30  4:44  5% [PATCH 00/11] viewvcs: more fixes Eric Wong
@ 2019-01-30  4:44  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-01-30  4:44 UTC (permalink / raw)
  To: meta

Proper ordering of destruction seems required to avoid segfaults
at shutdown.
---
 lib/PublicInbox/ViewVCS.pm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 63e503d..85edf22 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -26,6 +26,11 @@ my $hl = eval {
 	PublicInbox::HlMod->new;
 };
 
+# we need to trigger highlight::CodeGenerator::deleteInstance
+# in HlMod::DESTROY before the rest of Perl shuts down to avoid
+# a segfault at shutdown
+END { $hl = undef };
+
 my %QP_MAP = ( A => 'oid_a', B => 'oid_b', a => 'path_a', b => 'path_b' );
 my $max_size = 1024 * 1024; # TODO: configurable
 my $enc_utf8 = find_encoding('UTF-8');
-- 
@@ -26,6 +26,11 @@ my $hl = eval {
 	PublicInbox::HlMod->new;
 };
 
+# we need to trigger highlight::CodeGenerator::deleteInstance
+# in HlMod::DESTROY before the rest of Perl shuts down to avoid
+# a segfault at shutdown
+END { $hl = undef };
+
 my %QP_MAP = ( A => 'oid_a', B => 'oid_b', a => 'path_a', b => 'path_b' );
 my $max_size = 1024 * 1024; # TODO: configurable
 my $enc_utf8 = find_encoding('UTF-8');
-- 
EW


^ permalink raw reply related	[relevance 7%]

* [PATCH 00/11] viewvcs: more fixes
@ 2019-01-30  4:44  5% Eric Wong
  2019-01-30  4:44  7% ` [PATCH 06/11] viewvcs: avoid segfault with highlight.pm at shutdown Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-01-30  4:44 UTC (permalink / raw)
  To: meta

Been hammering away with check-www-inbox on git@vger without problems,
so I'll probably deploy this to the non-onion site soon...

And maybe I'll set the non-.onion to use 216dark, too...

Eric Wong (11):
  hval: add src_escape for highlight post-processing
  t/check-www-inbox: replace IPC::Run with PublicInbox::Spawn
  t/check-www-inbox: don't follow mboxes
  t/check-www-inbox: disable history
  solvergit: do not solve blobs twice
  viewvcs: avoid segfault with highlight.pm at shutdown
  css/216dark: add comments and tweak highlight colors
  solvergit: do not show full path names to "git apply"
  solvergit: avoid "Wide character" warnings
  solvergit: extract mode from diff headers properly
  solvergit: deal with alternative diff prefixes

 contrib/css/216dark.css        | 14 ++++++------
 lib/PublicInbox/Hval.pm        |  8 ++++++-
 lib/PublicInbox/SolverGit.pm   | 18 ++++++++++-----
 lib/PublicInbox/UserContent.pm | 14 ++++++------
 lib/PublicInbox/ViewVCS.pm     |  9 +++++++-
 t/check-www-inbox.perl         | 42 +++++++++++++++++++++++++++++-----
 t/hval.t                       |  3 +++
 7 files changed, 80 insertions(+), 28 deletions(-)

-- 
EW

^ permalink raw reply	[relevance 5%]

Results 1-2 of 2 | reverse | sort options + mbox downloads above
-- links below jump to the message on this page --
2019-01-30  4:44  5% [PATCH 00/11] viewvcs: more fixes Eric Wong
2019-01-30  4:44  7% ` [PATCH 06/11] viewvcs: avoid segfault with highlight.pm at shutdown Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).