* [PATCH 02/11] viewvcs: add path name hint based on `b=' query param
2023-01-24 9:49 5% [PATCH 00/11] www_coderepo: subjective web stuffs Eric Wong
@ 2023-01-24 9:49 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2023-01-24 9:49 UTC (permalink / raw)
To: meta
Of course, we need a note saying it's non-authoritative since
anybody can fiddle with the `b=' parameter in the URL.
---
lib/PublicInbox/ViewVCS.pm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 37b688ed..00db8ff2 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -501,8 +501,13 @@ sub solve_result {
return show_tag($ctx, $res) if $type eq 'tag';
return show_other($ctx, $res) if $type ne 'blob';
my $paths = $ctx->{-paths} //= do {
- my $path = to_filename($di->{path_b}//$hints->{path_b}//'blob');
+ my $fn = $di->{path_b} // $hints->{path_b};
+ my $path = to_filename($fn // 'blob');
my $raw_more = qq[(<a\nhref="$path">raw</a>)];
+
+ # XXX not sure if this is the correct wording
+ defined($fn) and $raw_more .=
+"\nname: ${\ascii_html($fn)} \t # note: path name is non-authoritative";
[ $path, $raw_more ];
};
^ permalink raw reply related [relevance 7%]
* [PATCH 00/11] www_coderepo: subjective web stuffs
@ 2023-01-24 9:49 5% Eric Wong
2023-01-24 9:49 7% ` [PATCH 02/11] viewvcs: add path name hint based on `b=' query param Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-01-24 9:49 UTC (permalink / raw)
To: meta
Aside from avoiding FD waste for /dev/null in common
deployments, there's not much _measurably_ better.
Eric Wong (11):
qspawn: drop lineno from command failure warning
viewvcs: add path name hint based on `b=' query param
viewvcs: prepopulate search bar with dfpost + dfn
www_coderepo: show /$INBOX/?t=$DATE link for commits
www_coderepo: eliminate debug log footer
http: reuse STDIN if it's already /dev/null
viewvcs: expand on path names being "non-authoritative"
viewvcs: show message for 404||500 errors
solver_git: remove extraneous leading `-'
www_coderepo: remove some needless return statements
viewvcs: improve tree glossary view
lib/PublicInbox/HTTP.pm | 8 ++++-
lib/PublicInbox/Qspawn.pm | 2 +-
lib/PublicInbox/RepoTree.pm | 3 +-
lib/PublicInbox/SolverGit.pm | 2 +-
lib/PublicInbox/ViewVCS.pm | 56 ++++++++++++++++++++++++++--------
lib/PublicInbox/WwwCoderepo.pm | 50 +++++++++++++++---------------
t/solver_git.t | 2 +-
7 files changed, 81 insertions(+), 42 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-01-24 9:49 5% [PATCH 00/11] www_coderepo: subjective web stuffs Eric Wong
2023-01-24 9:49 7% ` [PATCH 02/11] viewvcs: add path name hint based on `b=' query param Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).