* [PATCH 06/13] view: tweak thread/index header slightly
2016-06-30 9:21 6% [PATCH 0/13] www: hybrid flat+thread conversation view Eric Wong
@ 2016-06-30 9:21 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-06-30 9:21 UTC (permalink / raw)
To: meta
This makes the top permalink/raw as well as the In-Reply-To
show up without search. While we're at it, try to make
the links on the thread index from the "X siblings, Y replies"
more obvious.
---
lib/PublicInbox/View.pm | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 0b47c89..9393d44 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -119,8 +119,15 @@ sub index_entry {
my $dst = _hdr_names($hdr, $f);
push @tocc, "$f: $dst" if $dst ne '';
}
- $rv .= "From: "._hdr_names($hdr, 'From').' @ '._msg_date($hdr)." UTC\n";
+ my $mapping = $ctx->{mapping};
+ $rv .= "From: "._hdr_names($hdr, 'From').' @ '._msg_date($hdr)." UTC";
+ my $upfx = $ctx->{-upfx};
+ $rv .= qq{ (<a\nhref="$upfx$mid_raw/">permalink</a> / };
+ $rv .= qq{<a\nhref="$upfx$mid_raw/raw">raw</a>)\n};
$rv .= ' '.join('; +', @tocc) . "\n" if @tocc;
+ if (!$mapping && $irt) {
+ $rv .= qq(In-Reply-To: <<a\nhref="$upfx$irt/">$irt</a>>\n)
+ }
$rv .= "\n";
# scan through all parts, looking for displayable text
@@ -173,11 +180,7 @@ sub _th_index_lite {
if (my $next = $node->next) {
$rv .= $pad . $mapping->{$next->messageid}->[1];
}
- $rv .= "<a\nhref=#e$id\nid=m$id>.<a>\t\t\t";
- $rv .= "(<a\nhref=#r$id\n>$s_s, $s_c</a> / ";
- my $upfx = $ctx->{-upfx};
- $rv .= qq{<a\nhref="$upfx$mid_raw/">permalink</a> / };
- $rv .= qq{<a\nhref="$upfx$mid_raw/raw">raw</a>)\n};
+ $rv .= "<a\nhref=#e$id\nid=m$id>_<a> <a\nhref=#r$id\n>$s_s, $s_c</a>\n";
}
sub walk_thread {
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/13] www: hybrid flat+thread conversation view
@ 2016-06-30 9:21 6% Eric Wong
2016-06-30 9:21 7% ` [PATCH 06/13] view: tweak thread/index header slightly Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-06-30 9:21 UTC (permalink / raw)
To: meta
I've been long-dreaming of this and finally it's at least
publishable (I hope :x). This flat view with thread skeletons
is 100% more usable than the dumb old one, but a little slower
(naturally :<)
I was originally hoping to remove the threaded /t/ endpoint
conversation view entirely to reduce server/caching overheads
but I still find it more usable in some situations.
What I still enjoy is being able to toggle between
[flat|threaded] views.
Eric Wong (13):
www: implement hybrid flat+thread conversation view
www: use WwwStream for dumping thread and search views
view: show thread context in the thread-aware flat view
view: merge $state hash with existing $ctx
feed: add $INBOX/new.html endpoint
view: tweak thread/index header slightly
view: show more nearby messages in flat thread view
www: reinstate old thread view as an option
view: fix up some HTML injection via Message-ID vectors
view: default to flat/hybrid thread display
view: show thread size when linking to summary
view: fixup bad reference to new_msgid
www_stream: add response wrapper sub
TODO | 2 -
lib/PublicInbox/Feed.pm | 51 +++-
lib/PublicInbox/SearchView.pm | 141 +++++-----
lib/PublicInbox/View.pm | 590 +++++++++++++++++++++++-------------------
lib/PublicInbox/WWW.pm | 22 +-
lib/PublicInbox/WwwStream.pm | 20 +-
t/view.t | 3 +-
7 files changed, 464 insertions(+), 365 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-06-30 9:21 6% [PATCH 0/13] www: hybrid flat+thread conversation view Eric Wong
2016-06-30 9:21 7% ` [PATCH 06/13] view: tweak thread/index header slightly Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).