* [PATCH 2/2] view: split up --cc args for git-send-email
2016-07-21 1:23 5% [PATCH 0/2] www: navigation improvements (hopefully) Eric Wong
@ 2016-07-21 1:23 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-07-21 1:23 UTC (permalink / raw)
To: meta
Having long Cc: lines is inevitable for large threads
with many participants, and git-send-email only gained
the ability to recognize ',' in the "--cc" arg recently
with the release of git v2.6.0 in September 2015.
---
lib/PublicInbox/View.pm | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 5f99644..e0d81f0 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -59,7 +59,7 @@ sub msg_reply {
my ($arg, $link) = mailto_arg_link($hdr);
push @$arg, '/path/to/YOUR_REPLY';
- $arg = join(" \\\n ", '', @$arg);
+ $arg = ascii_html(join(" \\\n ", '', @$arg));
<<EOF
<hr><pre
id=R><b>Reply instructions:</b>
@@ -619,15 +619,15 @@ sub mailto_arg_link {
my $subj = $hdr->header('Subject') || '';
$subj = "Re: $subj" unless $subj =~ /\bRe:/i;
my $mid = $hdr->header_raw('Message-ID');
- push @arg, '--in-reply-to='.ascii_html(squote_maybe(mid_clean($mid)));
+ push @arg, '--in-reply-to='.squote_maybe(mid_clean($mid));
my $irt = uri_escape_utf8($mid);
delete $cc{$to};
- push @arg, '--to=' . ascii_html($to);
+ push @arg, "--to=$to";
$to = uri_escape_utf8($to);
$subj = uri_escape_utf8($subj);
- my $cc = join(',', sort values %cc);
- push @arg, '--cc=' . ascii_html($cc);
- $cc = uri_escape_utf8($cc);
+ my @cc = sort values %cc;
+ push(@arg, map { "--cc=$_" } @cc);
+ my $cc = uri_escape_utf8(join(',', @cc));
my $href = "mailto:$to?In-Reply-To=$irt&Cc=${cc}&Subject=$subj";
$href =~ s/%20/+/g;
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] www: navigation improvements (hopefully)
@ 2016-07-21 1:23 5% Eric Wong
2016-07-21 1:23 7% ` [PATCH 2/2] view: split up --cc args for git-send-email Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-07-21 1:23 UTC (permalink / raw)
To: meta
1/2 is purely subjective; 2/2 improves compatibility for
users of older git.
Eric Wong (2):
www: label sections and hopefully improve navigation
view: split up --cc args for git-send-email
lib/PublicInbox/View.pm | 31 ++++++++++++++++++-------------
lib/PublicInbox/WwwStream.pm | 2 +-
2 files changed, 19 insertions(+), 14 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-07-21 1:23 5% [PATCH 0/2] www: navigation improvements (hopefully) Eric Wong
2016-07-21 1:23 7% ` [PATCH 2/2] view: split up --cc args for git-send-email Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).