* [PATCH 2/4] view: simplify message threading dumpers
@ 2015-08-20 10:20 7% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2015-08-20 10:20 UTC (permalink / raw)
To: meta
---
lib/PublicInbox/View.pm | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index e29922e..fe701b1 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -498,6 +498,7 @@ sub anchor_for {
sub simple_dump {
my ($dst, $root, $node, $level) = @_;
+ return unless $node;
# $root = [ Root Message-ID, \%seen, $srch ];
if (my $x = $node->message) {
my $mid = $x->header('Message-ID');
@@ -527,8 +528,8 @@ sub simple_dump {
}
}
}
- simple_dump($dst, $root, $node->child, $level + 1) if $node->child;
- simple_dump($dst, $root, $node->next, $level) if $node->next;
+ simple_dump($dst, $root, $node->child, $level+1);
+ simple_dump($dst, $root, $node->next, $level);
}
sub thread_followups {
@@ -553,6 +554,7 @@ sub thread_html_head {
sub thread_entry {
my ($dst, $git, $state, $node, $level) = @_;
+ return unless $node;
# $state = [ $search_res, $seen, undef, 0 (msg_nr) ];
# $seen is overloaded with 3 types of fields:
# 1) "root_anchor" => anchor_for(Message-ID),
@@ -570,11 +572,8 @@ sub thread_entry {
$$dst .= index_entry(undef, $mime, $level, $state);
}
}
- my $cur;
- $cur = $node->child and
- thread_entry($dst, $git, $state, $cur, $level + 1);
- $cur = $node->next and
- thread_entry($dst, $git, $state, $cur, $level);
+ thread_entry($dst, $git, $state, $node->child, $level + 1);
+ thread_entry($dst, $git, $state, $node->next, $level);
}
sub load_results {
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2015-08-20 10:20 [PATCH 1/4] dead code cleanup Eric Wong
2015-08-20 10:20 7% ` [PATCH 2/4] view: simplify message threading dumpers Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).