* [PATCH 2/2] view: show To/Cc destinations in conversation view
2016-06-25 9:44 5% [PATCH 0/2] www: show To/Cc destinations in conversation view Eric Wong
@ 2016-06-25 9:44 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-06-25 9:44 UTC (permalink / raw)
To: meta
It is important to show the decentralized nature of
communication in our web views.
---
lib/PublicInbox/View.pm | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 9fa2a9b..d906276 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -83,6 +83,12 @@ sub in_reply_to {
undef;
}
+sub _hdr_names ($$) {
+ my ($hdr, $field) = @_;
+ my $val = $hdr->header($field) or return '';
+ ascii_html(join(', ', PublicInbox::Address::names($val)));
+}
+
# this is already inside a <pre>
sub index_entry {
my ($mime, $level, $state) = @_;
@@ -98,7 +104,6 @@ sub index_entry {
$seen->{$id} = "#$id"; # save the anchor for children, later
my $mid = PublicInbox::Hval->new_msgid($mid_raw);
- my $from = PublicInbox::Address::from_name($hdr->header('From'));
my $root_anchor = $state->{root_anchor} || '';
my $path = $root_anchor ? '../../' : '';
@@ -106,7 +111,6 @@ sub index_entry {
my $irt = in_reply_to($hdr);
my $parent_anchor = $seen->{anchor_for($irt)} if defined $irt;
- $from = ascii_html($from);
$subj = ascii_html($subj);
$subj = "<a\nhref=\"${path}$href/\">$subj</a>";
$subj = "<u\nid=u>$subj</u>" if $root_anchor eq $id;
@@ -116,7 +120,15 @@ sub index_entry {
$rv .= "<b\nid=$id>$subj</b>\n";
my $txt = "${path}$href/raw";
my $fh = $state->{fh};
- $fh->write($rv .= "- $from @ $ts UTC (<a\nhref=\"$txt\">raw</a>)\n\n");
+ my $from = _hdr_names($hdr, 'From');
+ $rv .= "- $from @ $ts UTC (<a\nhref=\"$txt\">raw</a>)\n";
+ my @tocc;
+ foreach my $f (qw(To Cc)) {
+ my $dst = _hdr_names($hdr, $f);
+ push @tocc, "$f: $dst" if $dst ne '';
+ }
+ $rv .= ' '.join('; +', @tocc) . "\n" if @tocc;
+ $fh->write($rv .= "\n");
my $mhref = "${path}$href/";
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] www: show To/Cc destinations in conversation view
@ 2016-06-25 9:44 5% Eric Wong
2016-06-25 9:44 7% ` [PATCH 2/2] view: " Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-06-25 9:44 UTC (permalink / raw)
To: meta
And improve our name/address extraction to do it.
Eric Wong (2):
address: beef up the module with name list extaction
view: show To/Cc destinations in conversation view
MANIFEST | 1 +
lib/PublicInbox/Address.pm | 13 ++++++++++++-
lib/PublicInbox/View.pm | 18 +++++++++++++++---
t/address.t | 21 +++++++++++++++++++++
4 files changed, 49 insertions(+), 4 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-06-25 9:44 5% [PATCH 0/2] www: show To/Cc destinations in conversation view Eric Wong
2016-06-25 9:44 7% ` [PATCH 2/2] view: " Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).