* [PATCH 1/4] view: remove unused parameter
2016-12-24 11:52 7% [PATCH 0/4] HTML micro-optimizations Eric Wong
@ 2016-12-24 11:52 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-12-24 11:52 UTC (permalink / raw)
To: meta
And add a comment about it to remind our future selves.
---
lib/PublicInbox/View.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index b779665..cf40b55 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -441,7 +441,7 @@ sub attach_link ($$$$;$) {
sub add_text_body {
my ($upfx, $p) = @_; # from msg_iter: [ Email::MIME, depth, @idx ]
- my ($part, $depth, @idx) = @$p;
+ my ($part, $depth) = @$p; # attachment @idx is unused
my $ct = $part->content_type || 'text/plain';
my $fn = $part->filename;
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/4] HTML micro-optimizations
@ 2016-12-24 11:52 7% Eric Wong
2016-12-24 11:52 7% ` [PATCH 1/4] view: remove unused parameter Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-12-24 11:52 UTC (permalink / raw)
To: meta
Testing with a horriblely long 368-message thread on git@vger,
I've found some minor tweaks which give us some tiny speedups.
Unfortunately, these are minor and new features may end up
costing us more in the future. Further optimizations are
needed.
Eric Wong (4):
view: remove unused parameter
view: stop chomping off whitespace at ends of messages
view: do not modify array during iteration
linkify: modify argument in place
lib/PublicInbox/Linkify.pm | 17 +++++++----------
lib/PublicInbox/View.pm | 21 +++++++++------------
2 files changed, 16 insertions(+), 22 deletions(-)
^ permalink raw reply [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-12-24 11:52 7% [PATCH 0/4] HTML micro-optimizations Eric Wong
2016-12-24 11:52 7% ` [PATCH 1/4] view: remove unused parameter Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).