* [PATCH 5/6] view: rely on internal query parser for 'o' param
2016-07-02 7:56 5% [PATCH 0/6] misc cleanups Eric Wong
@ 2016-07-02 7:56 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-07-02 7:56 UTC (permalink / raw)
To: meta
Plack::Request will check the request body by merely
calling "param", totally unnecessary and sneaky.
---
lib/PublicInbox/View.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index fd882aa..1527959 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -908,7 +908,7 @@ sub emit_topics {
sub emit_index_topics {
my ($ctx) = @_;
- my ($off) = (($ctx->{cgi}->param('o') || '0') =~ /(\d+)/);
+ my ($off) = (($ctx->{qp}->{o} || '0') =~ /(\d+)/);
$ctx->{order} = [];
$ctx->{subjs} = {};
$ctx->{latest} = {};
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/6] misc cleanups
@ 2016-07-02 7:56 5% Eric Wong
2016-07-02 7:56 7% ` [PATCH 5/6] view: rely on internal query parser for 'o' param Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-07-02 7:56 UTC (permalink / raw)
To: meta
Should be pretty obvious, and the iffstat looks good :)
Eric Wong (6):
TODO: clarify streaming Email::MIME replacement
inbox: base_url method takes PSGI env hashref instead
extmsg: rework to use Inbox objects
www: use PSGI env directly
view: rely on internal query parser for 'o' param
www: remove Plack::Request dependency entirely
TODO | 1 +
lib/PublicInbox/ExtMsg.pm | 102 ++++++++++++++++++------------------------
lib/PublicInbox/Feed.pm | 13 +++---
lib/PublicInbox/Inbox.pm | 17 +++++--
lib/PublicInbox/Mbox.pm | 2 +-
lib/PublicInbox/SearchView.pm | 2 +-
lib/PublicInbox/View.pm | 2 +-
lib/PublicInbox/WWW.pm | 24 +++++-----
lib/PublicInbox/WwwStream.pm | 9 +---
script/public-inbox-httpd | 1 -
t/httpd-corner.t | 2 +-
t/httpd-unix.t | 2 +-
t/httpd.t | 2 +-
t/plack.t | 2 +-
t/psgi_attach.t | 2 +-
t/psgi_mount.t | 2 +-
t/view.t | 1 +
17 files changed, 86 insertions(+), 100 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-07-02 7:56 5% [PATCH 0/6] misc cleanups Eric Wong
2016-07-02 7:56 7% ` [PATCH 5/6] view: rely on internal query parser for 'o' param Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).