* [PATCH 2/3] view: preserve attribution for current message
2016-07-07 3:11 6% [PATCH 0/3] view: visual and navigation tweaks Eric Wong
@ 2016-07-07 3:11 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-07-07 3:11 UTC (permalink / raw)
To: meta
It should be harmless if the "[this message]" text goes past
the boundary as we bold the entire line to make it stand out.
---
lib/PublicInbox/View.pm | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 7be72cf..f47ecba 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -735,16 +735,13 @@ sub _skel_header {
if ($attr ne $ctx->{prev_attr} || $ctx->{prev_level} > $level) {
$ctx->{prev_attr} = $attr;
- } else {
- $attr = '';
}
$ctx->{prev_level} = $level;
if ($cur) {
if ($cur eq $mid) {
delete $ctx->{cur};
- $$dst .= $d;
- $$dst .= "<b><a\nid=r\nhref=\"#t\">".
+ $$dst .= "<b>$d<a\nid=r\nhref=\"#t\">".
"$attr [this message]</a></b>\n";
return;
}
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/3] view: visual and navigation tweaks
@ 2016-07-07 3:11 6% Eric Wong
2016-07-07 3:11 7% ` [PATCH 2/3] view: preserve attribution for current message Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-07-07 3:11 UTC (permalink / raw)
To: meta
These little things should make the navigation experience a
little more tolerable in the per-message view.
Eric Wong (3):
view: reduce visual noise in conversation view
view: preserve attribution for current message
view: per-message view links to real previous sibling
lib/PublicInbox/View.pm | 57 ++++++++++++++++++++++++++++++-------------------
1 file changed, 35 insertions(+), 22 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-07-07 3:11 6% [PATCH 0/3] view: visual and navigation tweaks Eric Wong
2016-07-07 3:11 7% ` [PATCH 2/3] view: preserve attribution for current message Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).