* [PATCH] view: fix wrong date for non-Xapian/SQLite v1 users
@ 2019-01-08 10:34 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2019-01-08 10:34 UTC (permalink / raw)
To: meta
We need to parse the MIME object in order to get the
datestamp for those sites.
Fixes: 7d02b9e64455 ("view: stop storing all MIME objects on large threads")
---
lib/PublicInbox/View.pm | 3 ++-
t/plack.t | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 416cb4a..5ddb842 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -218,11 +218,12 @@ sub index_entry {
$rv .= $subj . "\n";
$rv .= _th_index_lite($mid_raw, \$irt, $id, $ctx);
my @tocc;
+ my $ds = $smsg->ds; # for v1 non-Xapian/SQLite users
my $mime = delete $smsg->{mime}; # critical to memory use
my $hdr = $mime->header_obj;
my $from = _hdr_names_html($hdr, 'From');
obfuscate_addrs($obfs_ibx, $from) if $obfs_ibx;
- $rv .= "From: $from @ ".fmt_ts($smsg->ds)." UTC";
+ $rv .= "From: $from @ ".fmt_ts($ds)." UTC";
my $upfx = $ctx->{-upfx};
my $mhref = $upfx . mid_escape($mid_raw) . '/';
$rv .= qq{ (<a\nhref="$mhref">permalink</a> / };
diff --git a/t/plack.t b/t/plack.t
index 9901186..2ff98e9 100644
--- a/t/plack.t
+++ b/t/plack.t
@@ -46,7 +46,7 @@ To: You <you\@example.com>
Cc: $addr
Message-Id: <blah\@example.com>
Subject: hihi
-Date: Thu, 01 Jan 1970 00:00:00 +0000
+Date: Fri, 02 Oct 1993 00:00:00 +0000
zzzzzz
EOF
@@ -129,6 +129,7 @@ EOF
'atom URL generated');
like($res->content, qr!href="blah\@example\.com/"!,
'index generated');
+ like($res->content, qr!1993-10-02!, 'date set');
});
test_psgi($app, sub {
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-01-08 10:34 7% [PATCH] view: fix wrong date for non-Xapian/SQLite v1 users Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).