* [PATCH 6/8] view: escape Subject HTML directly
2020-02-15 9:46 6% [PATCH 0/8] some view cleanups and minor bugfixes Eric Wong
@ 2020-02-15 9:46 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-02-15 9:46 UTC (permalink / raw)
To: meta
No need to use the over-engineered Hval OO API when the subject
is already normalized and there's no trailing spaces because of
normalization.
---
lib/PublicInbox/View.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 033a0c14..d4bfa62d 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -1090,7 +1090,7 @@ sub dump_topics {
my $mid = delete $seen->{$top_subj};
my $href = mid_escape($mid);
my $prev_subj = [ split(/ /, $top_subj) ];
- $top_subj = PublicInbox::Hval->new($top_subj)->as_html;
+ $top_subj = ascii_html($top_subj);
$ds = fmt_ts($ds);
# $n isn't the total number of posts on the topic,
^ permalink raw reply related [relevance 7%]
* [PATCH 0/8] some view cleanups and minor bugfixes
@ 2020-02-15 9:46 6% Eric Wong
2020-02-15 9:46 7% ` [PATCH 6/8] view: escape Subject HTML directly Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-02-15 9:46 UTC (permalink / raw)
To: meta
Pretty insignificant, but the diffstat makes me happy :>
Eric Wong (8):
view: remove mhref arg from multipart_text_as_html
view: single id="t" for multi-Subject messages
view: dump_topics: better naming of top Subject
view: cleanup topic accumulation and dumping
view,searchview: avoid smsg method calls when using SQLite/Xapian
view: escape Subject HTML directly
view: escape ampersand in Message-IDs
view: remove last Hval->new caller
lib/PublicInbox/ExtMsg.pm | 19 ++--
lib/PublicInbox/Hval.pm | 28 +-----
lib/PublicInbox/Linkify.pm | 9 +-
lib/PublicInbox/Reply.pm | 6 +-
lib/PublicInbox/SearchView.pm | 10 +--
lib/PublicInbox/View.pm | 144 ++++++++++++++-----------------
lib/PublicInbox/WwwAtomStream.pm | 12 +--
t/psgi_bad_mids.t | 9 +-
xt/perf-msgview.t | 3 +-
9 files changed, 104 insertions(+), 136 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-02-15 9:46 6% [PATCH 0/8] some view cleanups and minor bugfixes Eric Wong
2020-02-15 9:46 7% ` [PATCH 6/8] view: escape Subject HTML directly Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).