* [PATCH 1/2] view: do not kill whitespace in permalink thread timestamp
2016-01-30 23:39 6% [PATCH 0/2] view: permalink Thread: display cleanups Eric Wong
@ 2016-01-30 23:39 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-01-30 23:39 UTC (permalink / raw)
To: meta
There's no need to HTML escape a timestamp we generate ourselves.
We need to preserve the leading space and can't use the "oneline"
semantics to preserve alignment.
---
lib/PublicInbox/View.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index be18633..e72243b 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -772,7 +772,6 @@ sub _inline_header {
my $f = $mime->header('X-PI-From');
my $d = _msg_date($mime);
$f = PublicInbox::Hval->new_oneline($f)->as_html;
- $d = PublicInbox::Hval->new_oneline($d)->as_html;
my $pfx = ' ' . $d . ' ' . indent_for($level);
my $attr = $f;
$state->{first_level} ||= $level;
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] view: permalink Thread: display cleanups
@ 2016-01-30 23:39 6% Eric Wong
2016-01-30 23:39 7% ` [PATCH 1/2] view: do not kill whitespace in permalink thread timestamp Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-01-30 23:39 UTC (permalink / raw)
To: meta
I noticed some oddities in the pseudo "Thread:" header in the
per-message view from "permalink". These fix it.
I'm not sure if "Thread:" is a good word to display, even;
since it's not a real email header (at least not from the
raw message itself...)
Perhaps ":thread [ expand | mbox.gz | scroll down ]" makes things
more obvious?
2 changes:
view: do not kill whitespace in permalink thread timestamp
view: cleanup permalink Thread: header display
lib/PublicInbox/View.pm | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-01-30 23:39 6% [PATCH 0/2] view: permalink Thread: display cleanups Eric Wong
2016-01-30 23:39 7% ` [PATCH 1/2] view: do not kill whitespace in permalink thread timestamp Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).