* [PATCH 7/7] view: avoid intermediate array when streaming thread
2022-08-04 8:16 5% [PATCH 0/7] various op/allocation golfing Eric Wong
@ 2022-08-04 8:17 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2022-08-04 8:17 UTC (permalink / raw)
To: meta
We can rely on auto-vivification to avoid an intermediate
array for the map result.
---
lib/PublicInbox/View.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index fa96cca3..26094082 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2014-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
#
# Used for displaying the HTML web interface.
@@ -429,7 +429,7 @@ sub stream_thread_i { # PublicInbox::WwwStream::getline callback
sub stream_thread ($$) {
my ($rootset, $ctx) = @_;
- $ctx->{-queue} = [ map { (0, $_) } @$rootset ];
+ @{$ctx->{-queue}} = map { (0, $_) } @$rootset;
PublicInbox::WwwStream::aresponse($ctx, 200, \&stream_thread_i);
}
^ permalink raw reply related [relevance 7%]
* [PATCH 0/7] various op/allocation golfing
@ 2022-08-04 8:16 5% Eric Wong
2022-08-04 8:17 7% ` [PATCH 7/7] view: avoid intermediate array when streaming thread Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2022-08-04 8:16 UTC (permalink / raw)
To: meta
Nothing major, but some of these reduce Perl internal pad space,
which tends to add up across codebases with many cold paths.
Eric Wong (7):
http: coerce SERVER_PORT to integer
over: get_xref3: modify rows in-place
isearch: mset_to_artnums: avoid unnecessary ops
lei_overview: remove pointless map {} op
imap: ensure_slices_exist: drop needless map and array
feed: avoid unnecessary map loop in non-over path
view: avoid intermediate array when streaming thread
lib/PublicInbox/Feed.pm | 13 ++++++-------
lib/PublicInbox/HTTP.pm | 2 +-
lib/PublicInbox/IMAP.pm | 7 ++-----
lib/PublicInbox/Isearch.pm | 5 ++---
lib/PublicInbox/LeiOverview.pm | 2 +-
lib/PublicInbox/Over.pm | 8 ++++----
lib/PublicInbox/View.pm | 4 ++--
7 files changed, 18 insertions(+), 23 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2022-08-04 8:16 5% [PATCH 0/7] various op/allocation golfing Eric Wong
2022-08-04 8:17 7% ` [PATCH 7/7] view: avoid intermediate array when streaming thread Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).