user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 2/2] view: always show strict|loose note w/ multi-roots
  2024-01-01  1:07  5% [PATCH 0/2] www: re-sort messages for strict|loose matches Eric Wong
@ 2024-01-01  1:07  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2024-01-01  1:07 UTC (permalink / raw)
  To: meta

For thread skeletons with multiple roots, it makes sense to
note the strict|loose delineation even when the first message
matches the desired Message-ID.
---
 lib/PublicInbox/View.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index d81c66b7..02b93d7b 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -885,8 +885,8 @@ sub thread_results {
 			my $tip = splice(@$rootset, $idx, 1);
 			@$rootset = reverse @$rootset;
 			unshift @$rootset, $tip;
-			$ctx->{sl_note} = strict_loose_note($nr);
 		}
+		$ctx->{sl_note} = strict_loose_note($nr);
 	}
 	$rootset
 }

^ permalink raw reply related	[relevance 7%]

* [PATCH 0/2] www: re-sort messages for strict|loose matches
@ 2024-01-01  1:07  5% Eric Wong
  2024-01-01  1:07  7% ` [PATCH 2/2] view: always show strict|loose note w/ multi-roots Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2024-01-01  1:07 UTC (permalink / raw)
  To: meta; +Cc: Askar Safin

1/2 fixes the bug reported by Askar Safin, while 2/2 makes
the multi-rootedness of threads which triggered the bug more
obvious.

Both patches deployed to my lore mirror at yhbt.net/lore:
https://yhbt.net/lore/lkml/20231120011248.396012-1-stefanb@linux.ibm.com/T/

Eric Wong (2):
  over: re-sort Subject matches for WWW /T/ endpoint
  view: always show strict|loose note w/ multi-roots

 lib/PublicInbox/Over.pm | 5 +++++
 lib/PublicInbox/View.pm | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

^ permalink raw reply	[relevance 5%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2024-01-01  1:07  5% [PATCH 0/2] www: re-sort messages for strict|loose matches Eric Wong
2024-01-01  1:07  7% ` [PATCH 2/2] view: always show strict|loose note w/ multi-roots Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).