* [PATCH 2/2] view: actually omit subject text when dumping topics
2020-04-22 1:33 5% [PATCH 0/2] view: two display fixes for deduped subjects Kyle Meyer
@ 2020-04-22 1:33 7% ` Kyle Meyer
0 siblings, 0 replies; 2+ results
From: Kyle Meyer @ 2020-04-22 1:33 UTC (permalink / raw)
To: meta; +Cc: Kyle Meyer
Despite dump_topics() calling dedupe_subject() on the subject, the
index shows partly duplicated subjects, for example
` [PATCH 2/2] t/www_listing: avoid 'once' warnings
` [PATCH v2] t/www_listing: avoid 'once' warnings "
In the second line, the omission character " is appended, but the
entire subject is shown. To display the subject with duplicated parts
omitted, regenerate it from the array that is modified by
dedupe_subject().
---
lib/PublicInbox/View.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index c90eaf6a..30928fdb 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -1096,6 +1096,7 @@ sub dump_topics {
my @next_prev = @subj; # full copy
my $omit = dedupe_subject($prev_subj, \@subj, ' "');
$prev_subj = \@next_prev;
+ $subj = join(' ', @subj);
$subj = ascii_html($subj);
obfuscate_addrs($obfs_ibx, $subj) if $obfs_ibx;
$href = mid_href($mid);
--
2.26.0
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] view: two display fixes for deduped subjects
@ 2020-04-22 1:33 5% Kyle Meyer
2020-04-22 1:33 7% ` [PATCH 2/2] view: actually omit subject text when dumping topics Kyle Meyer
0 siblings, 1 reply; 2+ results
From: Kyle Meyer @ 2020-04-22 1:33 UTC (permalink / raw)
To: meta; +Cc: Kyle Meyer
Looking at a thread on https://public-inbox.org/meta/ today, I got
confused by what a stray " was doing after a subject. Poking around,
it seems the omission character is getting tacked on despite the
entire subject being displayed.
As I was locally debugging/testing my fix for that issue, I noticed "
popping up in a spot that it shouldn't, the line for the current
message in the thread overview shown at the top of a message.
[1/2] view: strip omission character from current message in thread view
[2/2] view: actually omit subject text when dumping topics
lib/PublicInbox/View.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
base-commit: 2289dc4ab72cb31475039e26cb10786e6bf573d2
--
2.26.0
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-04-22 1:33 5% [PATCH 0/2] view: two display fixes for deduped subjects Kyle Meyer
2020-04-22 1:33 7% ` [PATCH 2/2] view: actually omit subject text when dumping topics Kyle Meyer
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).