* [PATCH 4/7] v2writable: fix rethread cleanup
2020-08-07 1:13 6% [PATCH 0/7] index: --sequential-shard and other stuff Eric Wong
@ 2020-08-07 1:14 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-08-07 1:14 UTC (permalink / raw)
To: meta
We need to drop old ghosts properly while inside the
transaction, otherwise it becomes a no-op. This isn't a big
deal, as it only results in a few dangling DB rows and a
small amount of wasted space.
---
lib/PublicInbox/V2Writable.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index 344edbba..f98afa61 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -1244,13 +1244,13 @@ sub index_sync {
}
# work forwards through history
index_epoch($self, $sync, $_) for (0..$epoch_max);
+ $self->{over}->rethread_done($opt);
$self->done;
if (my $nr = $sync->{nr}) {
my $pr = $sync->{-opt}->{-progress};
$pr->('all.git '.sprintf($sync->{-regen_fmt}, $$nr)) if $pr;
}
- $self->{over}->rethread_done($opt);
# reindex does not pick up new changes, so we rerun w/o it:
if ($opt->{reindex}) {
^ permalink raw reply related [relevance 7%]
* [PATCH 0/7] index: --sequential-shard and other stuff
@ 2020-08-07 1:13 6% Eric Wong
2020-08-07 1:14 7% ` [PATCH 4/7] v2writable: fix rethread cleanup Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-08-07 1:13 UTC (permalink / raw)
To: meta
1/7 is a minor usability fix (more on the way)
5/7 is a major improvement for HDDs
6/7 is useful to developers, and may be useful to users
a few months down the line
And the rest are minor fixes related to indexing...
Eric Wong (7):
xapcmd: quietly no-op on indexlevel=basic
xapcmd: remove redundant searchidx require
xapcmd: drop outdated comment
v2writable: fix rethread cleanup
index: v2: indexSequentialShard / --sequential-shard option
index: support --xapian-only switch
index+xcpdb: rename `--no-sync' to `--no-fsync'
Documentation/public-inbox-config.pod | 6 ++
Documentation/public-inbox-index.pod | 55 ++++++++++++++-
Documentation/public-inbox-v2-format.pod | 11 ++-
Documentation/public-inbox-xcpdb.pod | 2 +-
lib/PublicInbox/Config.pm | 9 +--
lib/PublicInbox/OverIdx.pm | 2 +-
lib/PublicInbox/SearchIdx.pm | 6 +-
lib/PublicInbox/SearchIdxShard.pm | 10 ++-
lib/PublicInbox/V2Writable.pm | 88 ++++++++++++++++++++++--
lib/PublicInbox/WatchMaildir.pm | 2 +-
lib/PublicInbox/Xapcmd.pm | 18 ++---
script/public-inbox-index | 33 +++++++--
t/config.t | 6 +-
t/indexlevels-mirror.t | 24 +++++--
t/v2mirror.t | 14 ++++
15 files changed, 235 insertions(+), 51 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-08-07 1:13 6% [PATCH 0/7] index: --sequential-shard and other stuff Eric Wong
2020-08-07 1:14 7% ` [PATCH 4/7] v2writable: fix rethread cleanup Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).