* [PATCH 05/11] tests: add "use strict" and declare v5.10.1 compatibility
2020-09-02 11:04 5% [PATCH 00/11] cleanups, mostly indexing related Eric Wong
@ 2020-09-02 11:04 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-09-02 11:04 UTC (permalink / raw)
To: meta
strict.pm helped me find a typo in an upcoming recent change, so
ensure we use it since it does more good than harm. We'll also
take the opportunity here to declare v5.10.1 compatibility level
to future-proof against Perl incompatibilities.
---
t/index-git-times.t | 3 +++
xt/eml_check_limits.t | 2 ++
2 files changed, 5 insertions(+)
diff --git a/t/index-git-times.t b/t/index-git-times.t
index 8f80c866..73c99e61 100644
--- a/t/index-git-times.t
+++ b/t/index-git-times.t
@@ -1,5 +1,8 @@
+#!perl -w
# Copyright (C) 2020 all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
+use strict;
+use v5.10.1;
use Test::More;
use PublicInbox::TestCommon;
use PublicInbox::Import;
diff --git a/xt/eml_check_limits.t b/xt/eml_check_limits.t
index cf780c77..9f821946 100644
--- a/xt/eml_check_limits.t
+++ b/xt/eml_check_limits.t
@@ -1,6 +1,8 @@
#!perl -w
# Copyright (C) 2020 all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
+use strict;
+use v5.10.1;
use Test::More;
use PublicInbox::TestCommon;
use PublicInbox::Eml;
^ permalink raw reply related [relevance 7%]
* [PATCH 00/11] cleanups, mostly indexing related
@ 2020-09-02 11:04 5% Eric Wong
2020-09-02 11:04 7% ` [PATCH 05/11] tests: add "use strict" and declare v5.10.1 compatibility Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-09-02 11:04 UTC (permalink / raw)
To: meta
Some cleanups ahead of detached index support.
Found some dead code, too.
Eric Wong (11):
msgmap: note how we use ->created_at
disambiguate OverIdx and Over by field name
use more idiomatic internal API for ->over access
search: remove special case for blank query
tests: add "use strict" and declare v5.10.1 compatibility
search: replace ->query with ->mset
search: remove {over_ro} field
imap: drop old, pre-Parse::RecDescent search parser
wwwaltid: drop unused sqlite3_missing function
overidx: document column uses
v2writable: reuse read-only shard counting code
lib/PublicInbox/ExtMsg.pm | 4 +-
lib/PublicInbox/IMAP.pm | 63 +----------------
lib/PublicInbox/Inbox.pm | 11 ++-
lib/PublicInbox/Mbox.pm | 6 +-
lib/PublicInbox/Msgmap.pm | 1 +
lib/PublicInbox/OverIdx.pm | 18 ++---
lib/PublicInbox/Search.pm | 32 ++++-----
lib/PublicInbox/SearchIdx.pm | 32 ++++-----
lib/PublicInbox/SearchView.pm | 3 +-
lib/PublicInbox/SolverGit.pm | 5 +-
lib/PublicInbox/V2Writable.pm | 59 ++++++----------
lib/PublicInbox/WwwAltId.pm | 16 +----
scripts/dupe-finder | 3 +-
t/altid.t | 8 +--
t/altid_v2.t | 7 +-
t/index-git-times.t | 17 +++--
t/indexlevels-mirror.t | 8 +--
t/mda_filter_rubylang.t | 6 +-
t/replace.t | 8 +--
t/search-thr-index.t | 8 +--
t/search.t | 126 +++++++++++++++++-----------------
t/v1reindex.t | 4 +-
t/v2mda.t | 16 +++--
t/v2mirror.t | 24 +++----
t/v2reindex.t | 9 +--
t/v2writable.t | 14 ++--
t/watch_filter_rubylang.t | 12 ++--
t/watch_maildir_v2.t | 30 ++++----
t/xcpdb-reshard.t | 3 +-
xt/eml_check_limits.t | 2 +
xt/perf-threading.t | 2 +-
31 files changed, 232 insertions(+), 325 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-09-02 11:04 5% [PATCH 00/11] cleanups, mostly indexing related Eric Wong
2020-09-02 11:04 7% ` [PATCH 05/11] tests: add "use strict" and declare v5.10.1 compatibility Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).