* [PATCH 2/3] testcommon: prepare_redirects: fix error message
2021-01-03 9:48 6% [PATCH 0/3] lei-related test fixes Eric Wong
@ 2021-01-03 9:48 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-01-03 9:48 UTC (permalink / raw)
To: meta
I never hit these die() calls, but noticed it while debugging
another problem on FreeBSD.
---
lib/PublicInbox/TestCommon.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index 56f04bd4..16ae2650 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -141,9 +141,9 @@ sub _prepare_redirects ($) {
for (my $fd = 0; $fd <= $#io_mode; $fd++) {
my $fh = $fhref->[$fd] or next;
my ($oldfh, $mode) = @{$io_mode[$fd]};
- open my $orig, $mode, $oldfh or die "$$oldfh $mode stash: $!";
+ open my $orig, $mode, $oldfh or die "$oldfh $mode stash: $!";
$orig_io->[$fd] = $orig;
- open $oldfh, $mode, $fh or die "$$oldfh $mode redirect: $!";
+ open $oldfh, $mode, $fh or die "$oldfh $mode redirect: $!";
}
$orig_io;
}
^ permalink raw reply related [relevance 7%]
* [PATCH 0/3] lei-related test fixes
@ 2021-01-03 9:48 6% Eric Wong
2021-01-03 9:48 7% ` [PATCH 2/3] testcommon: prepare_redirects: fix error message Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-01-03 9:48 UTC (permalink / raw)
To: meta
Still chasing down a weird problem which causes t/lei.t and
t/lei-oneshot.t to fail on FreeBSD 11.4 with IO::FDPass under
high load. No syscall errors are reported, but it's like the
FDs aren't passed at all... Maybe it's fixed in 12.x
1/3 is to cut down on noise
2/3 is a no-brainer :x
3/3 was for me to play around with, but also avoids malloc and
a potential leak in IO::FDPass (upstream's been notified).
However, I'm considering just making our C code pass all
3 FDs with one syscall since it's possible.
In any case, the C parts of PublicInbox::Spawn should probably
renamed PublicInbox::C...
Eric Wong (3):
t/lei: use $lei->() callback wrapper
testcommon: prepare_redirects: fix error message
spawn: support send_fd+recv_fd w/o IO::FDPass
lib/PublicInbox/LEI.pm | 6 ++-
lib/PublicInbox/Spawn.pm | 78 ++++++++++++++++++++++++++++++--
lib/PublicInbox/TestCommon.pm | 4 +-
script/lei | 7 ++-
t/lei.t | 84 ++++++++++++++++-------------------
t/spawn.t | 18 ++++++++
6 files changed, 141 insertions(+), 56 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-01-03 9:48 6% [PATCH 0/3] lei-related test fixes Eric Wong
2021-01-03 9:48 7% ` [PATCH 2/3] testcommon: prepare_redirects: fix error message Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).