* [PATCH 4/5] test_common: remove non-hidden files, first
2021-09-14 2:39 4% [PATCH 0/5] lei: TEST_LEI_DAEMON_PERSIST bugfixes Eric Wong
@ 2021-09-14 2:39 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-09-14 2:39 UTC (permalink / raw)
To: meta
We want to remove any inotify-watched files before removing
~/.local/lei/store/ipc.lock, since sto_done_request was failing
on attempts to lock a non-existent lei/store/ipc.lock file.
---
lib/PublicInbox/TestCommon.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index d8346673..0ee4b228 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -567,7 +567,10 @@ SKIP: {
}
local $ENV{XDG_RUNTIME_DIR} = $daemon_xrd;
$cb->();
- unless ($persist) {
+ if ($persist) { # remove before ~/.local gets removed
+ File::Path::rmtree([glob("$home/*")]);
+ File::Path::rmtree("$home/.config");
+ } else {
lei_ok(qw(daemon-pid), \"daemon-pid after $t");
chomp($daemon_pid = $lei_out);
if (!$daemon_pid) {
^ permalink raw reply related [relevance 7%]
* [PATCH 0/5] lei: TEST_LEI_DAEMON_PERSIST bugfixes
@ 2021-09-14 2:39 4% Eric Wong
2021-09-14 2:39 7% ` [PATCH 4/5] test_common: remove non-hidden files, first Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-09-14 2:39 UTC (permalink / raw)
To: meta
The 5/5 "lei up" fix has real-world implications if you're
using it in parallel. Otherwise, it's test-only stuff, and
`make check-run TEST_LEI_DAEMON_PERSIST=1 N=$(nproc)`
seems to fail or stall less often than before (but it
still can...).
(persisting the lei-daemon is around 5% faster with check-run)
Eric Wong (5):
lei: warn on event loop errors
lei: sto_done_request: add eval guard
t/run: TEST_LEI_DAEMON_PERSIST: die if pid changes
test_common: remove non-hidden files, first
lei up: fix env/cwd mismatches with multiple folders
lib/PublicInbox/LEI.pm | 33 ++++++++++++++++-----------------
lib/PublicInbox/LeiUp.pm | 15 +++++++--------
lib/PublicInbox/TestCommon.pm | 5 ++++-
t/run.perl | 3 +++
4 files changed, 30 insertions(+), 26 deletions(-)
^ permalink raw reply [relevance 4%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-09-14 2:39 4% [PATCH 0/5] lei: TEST_LEI_DAEMON_PERSIST bugfixes Eric Wong
2021-09-14 2:39 7% ` [PATCH 4/5] test_common: remove non-hidden files, first Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).