* Re: [PATCH] gcf2: die if pkg-config is missing
@ 2021-09-09 21:34 7% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2021-09-09 21:34 UTC (permalink / raw)
To: Konstantin Ryabitsev; +Cc: meta
Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> On Thu, Sep 09, 2021 at 09:23:48PM +0000, Eric Wong wrote:
> > > Annoyingly, after I blow away the container to start fresh, I get:
> > >
> > > t/gcf2.t ..................... skipped: PublicInbox::Gcf2 missing for t/gcf2.t
> > >
> > > That means gcf2 isn't getting built, right?
> >
> > Yeah, assuming all dependencies are there;
> > is PERL_INLINE_DIRECTORY set (or ~/.cache/public-inbox/inline-c exists?)
>
> Ah, yes, when I build as part of the dockerfile image, that dir is absent.
> It shouldn't matter for actual usage, though -- so we can ignore this.
>
> Sorry for a lot of noise about it, just want to make sure I got everything
> working. :)
>
> I'll follow up with my draft instructions on how to get things running with
> toolbox.
No worries, I think the test can show diagnostic info without
being too alarming for optional dependencies:
--------8<--------
Subject: [PATCH] test_common: print diagnostic for missing dependencies
The "#" prefix should prevent it from being too alarming if
a dependency is expected to be missing, but still useful if a
dependency is misconfigured.
---
lib/PublicInbox/TestCommon.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index 83dcf650..2e3e9ecc 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -144,6 +144,7 @@ sub require_mods {
eval "require $mod";
}
if ($@) {
+ diag "require $mod: $@";
push @need, $mod;
} elsif ($mod eq 'IO::Socket::SSL' &&
# old versions of IO::Socket::SSL aren't supported
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-09-09 18:23 make test in a debian-11 container Konstantin Ryabitsev
2021-09-09 20:45 ` [PATCH] gcf2: die if pkg-config is missing Eric Wong
2021-09-09 21:01 ` Konstantin Ryabitsev
2021-09-09 21:14 ` Eric Wong
2021-09-09 21:21 ` Konstantin Ryabitsev
2021-09-09 21:23 ` Eric Wong
2021-09-09 21:29 ` Konstantin Ryabitsev
2021-09-09 21:34 7% ` Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).