* [PATCH] test_common: don't attempt to seek on pipes and terminals
@ 2021-04-24 20:09 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2021-04-24 20:09 UTC (permalink / raw)
To: meta
This allows proper error reporting on daemon failure
when using "check-run".
---
lib/PublicInbox/TestCommon.pm | 1 +
t/run.perl | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index 49cecacd..09256852 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -321,6 +321,7 @@ sub run_script ($;$$) {
# slurp the redirects back into user-supplied strings
for my $fd (1..2) {
my $fh = $fhref->[$fd] or next;
+ next unless -f $fh;
seek($fh, 0, SEEK_SET) or die "seek: $!";
my $redir = $opt->{$fd};
local $/;
diff --git a/t/run.perl b/t/run.perl
index 1fb1c5f0..f4e235b7 100755
--- a/t/run.perl
+++ b/t/run.perl
@@ -225,6 +225,6 @@ for (my $i = $repeat; $i != 0; $i--) {
print $OLDOUT "1..".($repeat * scalar(@tests))."\n" if $repeat >= 0;
if ($lei_env && $$ == $owner_pid) {
- my $opt = {}; # 1 => $OLDOUT, 2 => $OLDERR };
+ my $opt = { 1 => $OLDOUT, 2 => $OLDERR };
run_script([qw(lei daemon-kill)], $lei_env, $opt);
}
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-04-24 20:09 7% [PATCH] test_common: don't attempt to seek on pipes and terminals Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).