* [PATCH] t/multi-mid: don't access ~/.public-inbox/config
@ 2020-02-06 9:18 5% Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2020-02-06 9:18 UTC (permalink / raw)
To: meta
It can cause unpredictable behavior and also slow things down.
Followup-to: e4d3be19612b2082 ("t: localize the PI_CONFIG env")
---
t/multi-mid.t | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/multi-mid.t b/t/multi-mid.t
index 0d283a0d..94c0e0a2 100644
--- a/t/multi-mid.t
+++ b/t/multi-mid.t
@@ -48,8 +48,8 @@ for my $order ([$bad, $good], [$good, $bad]) {
}
my $rdr = { 1 => \(my $out = ''), 2 => \(my $err = '') };
my $cmd = [ '-convert', $ibx->{inboxdir}, "$tmpdir/v2" ];
- ok(run_script($cmd, undef, $rdr),
- 'convert to v2');
+ my $env = { PI_DIR => "$tmpdir/.public-inbox" };
+ ok(run_script($cmd, $env, $rdr), 'convert to v2');
$err =~ s!\AW: $tmpdir/v1 not configured[^\n]+\n!!s;
is($err, '', 'no errors or warnings from -convert');
$ibx->{version} = 2;
^ permalink raw reply related [relevance 5%]
* [PATCH 1/7] t: localize the PI_CONFIG env
2019-11-29 10:14 5% [PATCH 0/7] some low impact changes and cleanups Eric Wong
@ 2019-11-29 10:14 7% ` Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2019-11-29 10:14 UTC (permalink / raw)
To: meta
We don't want the user's ~/.public-inbox/config to be read from
during tests. I only noticed this because I had a non-existent
pathname for one of my inboxes :x
I've also verified this change by running "inotifywait
~/.public-inbox/config -m" in another terminal while running
"make check"; (perhaps a portable solution could make it
into the test suite).
---
t/indexlevels-mirror.t | 1 +
t/xcpdb-reshard.t | 1 +
2 files changed, 2 insertions(+)
diff --git a/t/indexlevels-mirror.t b/t/indexlevels-mirror.t
index f1c338e1..3d4813be 100644
--- a/t/indexlevels-mirror.t
+++ b/t/indexlevels-mirror.t
@@ -32,6 +32,7 @@ sub import_index_incremental {
my ($v, $level) = @_;
my $this = "pi-$v-$level-indexlevels";
my ($tmpdir, $for_destroy) = tmpdir();
+ local $ENV{PI_CONFIG} = "$tmpdir/config";
my $ibx = PublicInbox::Inbox->new({
inboxdir => "$tmpdir/testbox",
name => $this,
diff --git a/t/xcpdb-reshard.t b/t/xcpdb-reshard.t
index ebf156a3..a4ab35d6 100644
--- a/t/xcpdb-reshard.t
+++ b/t/xcpdb-reshard.t
@@ -25,6 +25,7 @@ my $mime = PublicInbox::MIME->create(
my ($this) = (split('/', $0))[-1];
my ($tmpdir, $for_destroy) = tmpdir();
+local $ENV{PI_CONFIG} = "$tmpdir/config";
my $ibx = PublicInbox::Inbox->new({
inboxdir => "$tmpdir/testbox",
name => $this,
^ permalink raw reply related [relevance 7%]
* [PATCH 0/7] some low impact changes and cleanups
@ 2019-11-29 10:14 5% Eric Wong
2019-11-29 10:14 7% ` [PATCH 1/7] t: localize the PI_CONFIG env Eric Wong
0 siblings, 1 reply; 3+ results
From: Eric Wong @ 2019-11-29 10:14 UTC (permalink / raw)
To: meta
Some other changes coming in the next few days, I hope;
but the straightforward stuff, first...
Eric Wong (7):
t: localize the PI_CONFIG env
t/common: set $0 when running script w/o fork
ds: ->Reset initializes $nextq
TODO: update and add a few more items
tests: don't repeatly validate NEWS.atom
spawn: remove support for clearing the env
import: (cleanup) drop redundant env arg to run_die
.gitignore | 1 +
Documentation/include.mk | 5 +++--
TODO | 12 +++++++++---
lib/PublicInbox/DS.pm | 5 +++--
lib/PublicInbox/Import.pm | 4 ++--
lib/PublicInbox/Spawn.pm | 12 +-----------
t/common.perl | 1 +
t/indexlevels-mirror.t | 1 +
t/spawn.t | 10 ----------
t/xcpdb-reshard.t | 1 +
10 files changed, 22 insertions(+), 30 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-3 of 3 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-11-29 10:14 5% [PATCH 0/7] some low impact changes and cleanups Eric Wong
2019-11-29 10:14 7% ` [PATCH 1/7] t: localize the PI_CONFIG env Eric Wong
2020-02-06 9:18 5% [PATCH] t/multi-mid: don't access ~/.public-inbox/config Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).