* [PATCH 19/20] t/xcpdb-reshard: use 'shard' term in local variables
2019-06-15 8:46 7% [PATCH 00/20] v2: use consistent terminology Eric Wong
@ 2019-06-15 8:47 6% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-06-15 8:47 UTC (permalink / raw)
To: meta
Another step in maintaining consistency with Xapian docs.
---
t/xcpdb-reshard.t | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/t/xcpdb-reshard.t b/t/xcpdb-reshard.t
index bf56404..d921e12 100644
--- a/t/xcpdb-reshard.t
+++ b/t/xcpdb-reshard.t
@@ -43,8 +43,8 @@ for my $i (1..$ndoc) {
ok($im->add($mime), "message $i added");
}
$im->done;
-my @parts = grep(m!/\d+\z!, glob("$ibx->{mainrepo}/xap*/*"));
-is(scalar(@parts), $nproc, 'got expected parts');
+my @shards = grep(m!/\d+\z!, glob("$ibx->{mainrepo}/xap*/*"));
+is(scalar(@shards), $nproc, 'got expected shards');
my $orig = $ibx->over->query_xover(1, $ndoc);
my %nums = map {; "$_->{num}" => 1 } @$orig;
@@ -52,8 +52,8 @@ my %nums = map {; "$_->{num}" => 1 } @$orig;
for my $R (qw(2 4 1 3 3)) {
delete $ibx->{search}; # release old handles
is(system(@xcpdb, "-R$R", $ibx->{mainrepo}), 0, "xcpdb -R$R");
- my @new_parts = grep(m!/\d+\z!, glob("$ibx->{mainrepo}/xap*/*"));
- is(scalar(@new_parts), $R, 'resharded to two parts');
+ my @new_shards = grep(m!/\d+\z!, glob("$ibx->{mainrepo}/xap*/*"));
+ is(scalar(@new_shards), $R, 'resharded to two shards');
my $msgs = $ibx->search->query('s:this');
is(scalar(@$msgs), $ndoc, 'got expected docs after resharding');
my %by_mid = map {; "$_->{mid}" => $_ } @$msgs;
@@ -64,7 +64,7 @@ for my $R (qw(2 4 1 3 3)) {
# ensure docids in Xapian match NNTP article numbers
my $tot = 0;
my %tmp = %nums;
- foreach my $d (@new_parts) {
+ foreach my $d (@new_shards) {
my $xdb = Search::Xapian::Database->new($d);
$tot += $xdb->get_doccount;
my $it = $xdb->postlist_begin('');
--
EW
^ permalink raw reply related [relevance 6%]
* [PATCH 00/20] v2: use consistent terminology
@ 2019-06-15 8:46 7% Eric Wong
2019-06-15 8:47 6% ` [PATCH 19/20] t/xcpdb-reshard: use 'shard' term in local variables Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-06-15 8:46 UTC (permalink / raw)
To: meta
Modern Xapian docs and code refer to multi-DB uses as "shards";
so replace the term "partition" with the term "shard". This
way, we'll minimize the learning curve for people new to
public-inbox or Xapian.
We also still had a few places where we referred to git epochs
as "partitions", so fix those up and be consistent with the
majority of our own docs and code.
Eric Wong (20):
doc: rename our Xapian "partitions" to "shards"
v2writable: update comments regarding xcpdb --reshard
admin|xapcmd: user-facing messages say "shard"
rename reference to git epochs as "partitions"
searchidxpart: start using "shard" in user-visible places
v2writable: count_partitions => count_shards
v2writable: rename {partitions} field to {shards}
tests: change messages to use "shard" instead of partition
inboxwritable: s/partitions/shards/ in local var
v2: rename SearchIdxPart => SearchIdxShard
xapcmd: update comments referencing "partitions"
search*: rename {partition} => {shard}
v2writable: avoid "part" in internal subs and fields
v2writable: rename local vars to match Xapian terminology
adminedit: "part" => "shard" for local variables
v2writable: use "epoch" consistently when referring to git repos
search: use "shard" for local variable
xapcmd: favor 'shard' over 'part' in local variables
t/xcpdb-reshard: use 'shard' term in local variables
comments: replace "partition" with "shard"
Documentation/public-inbox-v2-format.pod | 10 +-
Documentation/public-inbox-xcpdb.pod | 11 +-
MANIFEST | 2 +-
lib/PublicInbox/Admin.pm | 4 +-
lib/PublicInbox/AdminEdit.pm | 12 +-
lib/PublicInbox/Inbox.pm | 18 +--
lib/PublicInbox/InboxWritable.pm | 4 +-
lib/PublicInbox/Search.pm | 14 +--
lib/PublicInbox/SearchIdx.pm | 19 +--
.../{SearchIdxPart.pm => SearchIdxShard.pm} | 30 ++---
lib/PublicInbox/V2Writable.pm | 109 +++++++++---------
lib/PublicInbox/WWW.pm | 12 +-
lib/PublicInbox/WwwListing.pm | 2 +-
lib/PublicInbox/WwwStream.pm | 12 +-
lib/PublicInbox/Xapcmd.pm | 96 +++++++--------
t/indexlevels-mirror.t | 2 +-
t/psgi_v2.t | 2 +-
t/v2writable.t | 4 +-
t/view.t | 2 +-
t/xcpdb-reshard.t | 14 +--
20 files changed, 188 insertions(+), 191 deletions(-)
rename lib/PublicInbox/{SearchIdxPart.pm => SearchIdxShard.pm} (78%)
--
EW
^ permalink raw reply [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-06-15 8:46 7% [PATCH 00/20] v2: use consistent terminology Eric Wong
2019-06-15 8:47 6% ` [PATCH 19/20] t/xcpdb-reshard: use 'shard' term in local variables Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).