user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 2/3] t/www_listing: reword grok-pull skip message
  2021-02-21 21:46  7% [PATCH 0/3] t/www_listing: update for Grokmirror v2 Kyle Meyer
@ 2021-02-21 21:46  6% ` Kyle Meyer
  0 siblings, 0 replies; 2+ results
From: Kyle Meyer @ 2021-02-21 21:46 UTC (permalink / raw)
  To: meta

Make it clear that this skip is because grok-pull isn't available at
all because the next commit will add another skip for older versions
of Grokmirror.
---
 t/www_listing.t | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/www_listing.t b/t/www_listing.t
index cdf2a1847a945225..bf35530f3494c016 100644
--- a/t/www_listing.t
+++ b/t/www_listing.t
@@ -121,7 +121,7 @@ SKIP: {
 	tiny_test($json, $host, $port);
 
 	my $grok_pull = which('grok-pull') or
-		skip('skipping grok-pull integration test', 12);
+		skip('grok-pull not available', 12);
 
 	ok(mkdir("$tmpdir/mirror"), 'prepare grok mirror dest');
 	open $fh, '>', "$tmpdir/repos.conf" or die;
-- 
2.30.1


^ permalink raw reply related	[relevance 6%]

* [PATCH 0/3] t/www_listing: update for Grokmirror v2
@ 2021-02-21 21:46  7% Kyle Meyer
  2021-02-21 21:46  6% ` [PATCH 2/3] t/www_listing: reword grok-pull skip message Kyle Meyer
  0 siblings, 1 reply; 2+ results
From: Kyle Meyer @ 2021-02-21 21:46 UTC (permalink / raw)
  To: meta

The test suite is failing on my end due to incompatibilities with
Grokmirror v2:

  ERROR: Section [core] must exist in: /tmp/pi-www_listing-4290-4AZck2/repos.conf
         Perhaps this is a grokmirror-1.x config file?

Patch 3 switches the generated manifest to be compatible with v2,
skipping the tests for older Grokmirror versions.

  [1/3] t/www_listing: correct the number of tests for grok-pull skip
  [2/3] t/www_listing: reword grok-pull skip message
  [3/3] t/www_listing: require grok-pull version 2 or later

 t/www_listing.t | 36 +++++++++++++++++++++---------------
 1 file changed, 21 insertions(+), 15 deletions(-)


base-commit: dda6a67ce8865641edad51f83aab2eb2fc27bda8
-- 
2.30.1


^ permalink raw reply	[relevance 7%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-02-21 21:46  7% [PATCH 0/3] t/www_listing: update for Grokmirror v2 Kyle Meyer
2021-02-21 21:46  6% ` [PATCH 2/3] t/www_listing: reword grok-pull skip message Kyle Meyer

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).