* [PATCH 1/3] t/v1reindex.t: fix typo in setting `indexlevel'
2019-05-27 18:45 5% ` [PATCH 0/3] fix --reindex skipping NNTP article numbers Eric Wong
@ 2019-05-27 18:45 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-05-27 18:45 UTC (permalink / raw)
To: meta
It did not cause a test failure because the default fallback
is `indexlevel=full'
---
t/v1reindex.t | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/v1reindex.t b/t/v1reindex.t
index 402ecd7..35275fb 100644
--- a/t/v1reindex.t
+++ b/t/v1reindex.t
@@ -223,7 +223,7 @@ ok(!-d $xap, 'Xapian directories removed again');
my @warn;
local $SIG{__WARN__} = sub { push @warn, @_ };
my %config = %$ibx_config;
- $config{indexleve} = 'medium';
+ $config{indexlevel} = 'medium';
my $ibx = PublicInbox::Inbox->new(\%config);
my $rw = PublicInbox::SearchIdx->new($ibx, 1);
eval { $rw->index_sync };
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/3] fix --reindex skipping NNTP article numbers
@ 2019-05-27 18:45 5% ` Eric Wong
2019-05-27 18:45 7% ` [PATCH 1/3] t/v1reindex.t: fix typo in setting `indexlevel' Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-05-27 18:45 UTC (permalink / raw)
To: meta
I was working on v2 cleanups and progress-reporting,
and speeding up no-op 'public-inbox-index' invocations when
I noticed --reindex showing higher-than-expected NNTP
article numbers with the verbose output I'm working on.
There's some (apparently) inconsequential typo fixes, too.
I think the v1 --reindex code is alright, after all, but
maybe I haven't been paying enough attention to it...
Also, I've noticed the v1 indexing code works around a Xapian
v1.2.20..v1.2.24 bug wrt OFD locks which the newer v2 code
doesn't (since v2 was developed mainly on Xapian 1.4.3+).
Not sure who uses Xapian 1.2, still; but it might still be
worth fixing for folks on older systems.
Eric Wong (3):
t/v1reindex.t: fix typo in setting `indexlevel'
searchidx: fix obvious typo
v2: fix reindex skipping NNTP article numbers
lib/PublicInbox/SearchIdx.pm | 2 +-
lib/PublicInbox/V2Writable.pm | 25 ++++++++++++++++++++++++-
t/indexlevels-mirror.t | 25 +++++++++++++++++++++++++
t/v1reindex.t | 2 +-
4 files changed, 51 insertions(+), 3 deletions(-)
--
EW
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-05-25 19:57 --reindex buggy wrt NNTP numbers, fixes coming Eric Wong
2019-05-27 18:45 5% ` [PATCH 0/3] fix --reindex skipping NNTP article numbers Eric Wong
2019-05-27 18:45 7% ` [PATCH 1/3] t/v1reindex.t: fix typo in setting `indexlevel' Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).