* [PATCH 4/4] t/search.t: update permissions check for OpenBSD
2019-12-22 22:17 5% [PATCH 0/4] support SWIG-generated Xapian binding Eric Wong
@ 2019-12-22 22:17 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-12-22 22:17 UTC (permalink / raw)
To: meta
OpenBSD (tested 6.5 on amd64) seems to follow the same semantics
as FreeBSD for S_ISGID, even if config.mak.uname in git.git
doesn't say so.
---
t/search.t | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/search.t b/t/search.t
index c40e1363..b9aa995b 100644
--- a/t/search.t
+++ b/t/search.t
@@ -438,9 +438,9 @@ $ibx->with_umask(sub {
my $all_mask = 07777;
my $dir_mask = 02770;
-# FreeBSD does not allow non-root users to set S_ISGID, so
-# git doesn't set it, either (see DIR_HAS_BSD_GROUP_SEMANTICS in git.git)
-if ($^O =~ /freebsd/i) {
+# FreeBSD and apparently OpenBSD does not allow non-root users to set S_ISGID,
+# so git doesn't set it, either (see DIR_HAS_BSD_GROUP_SEMANTICS in git.git)
+if ($^O =~ /(?:free|open)bsd/i) {
$all_mask = 0777;
$dir_mask = 0770;
}
^ permalink raw reply related [relevance 7%]
* [PATCH 0/4] support SWIG-generated Xapian binding
@ 2019-12-22 22:17 5% Eric Wong
2019-12-22 22:17 7% ` [PATCH 4/4] t/search.t: update permissions check for OpenBSD Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-12-22 22:17 UTC (permalink / raw)
To: meta
Xapian upstream is slowly migrating to a SWIG-generated
Perl binding and plans to drop the XS-based Search::Xapian
at some point: https://trac.xapian.org/ticket/523
The SWIG-generated "Xapian" binding seems to work fine with
some minor tweaks to our own code, and we can support both
the old and new bindings.
OpenBSD (tested 6.5) only has the SWIG-generated binding,
FreeBSD packages both, and Debian only has Search::Xapian.
With this, OpenBSD users may now enjoy Xapian-based search.
PATCH 1/4 is is a huge cleanup for our test cases, making
PATCH 3/4 easier-to-implement. I'm kinda annoyed at PATCH 2/4
because I'm no fan of operator overloading, but oh well,
we used "!=" instead of "->nequal" in those loop, anyways :x
Eric Wong (4):
testcommon: add require_mods method and use it
searchidx: call "++" on PostingIterator instead of "->inc"
search: support SWIG-generated Xapian.pm
t/search.t: update permissions check for OpenBSD
lib/PublicInbox/Admin.pm | 4 +++
lib/PublicInbox/Search.pm | 57 ++++++++++++++++++++++++-----------
lib/PublicInbox/SearchIdx.pm | 36 ++++++++++++++--------
lib/PublicInbox/SearchMsg.pm | 3 +-
lib/PublicInbox/TestCommon.pm | 24 ++++++++++++++-
lib/PublicInbox/V2Writable.pm | 5 ++-
lib/PublicInbox/Xapcmd.pm | 25 +++++++++------
t/altid.t | 6 +---
t/altid_v2.t | 6 +---
t/convert-compact.t | 6 +---
t/edit.t | 7 +----
t/filter_rubylang.t | 3 +-
t/httpd-corner.t | 9 ++----
t/httpd-https.t | 7 ++---
t/httpd-unix.t | 10 ++----
t/httpd.t | 8 ++---
t/indexlevels-mirror.t | 9 ++----
t/init.t | 5 +--
t/mda_filter_rubylang.t | 7 +----
t/msgmap.t | 7 +----
t/nntp.t | 8 ++---
t/nntpd-tls.t | 7 ++---
t/nntpd.t | 13 ++++----
t/over.t | 6 +---
t/plack.t | 5 +--
t/psgi_attach.t | 5 +--
t/psgi_bad_mids.t | 5 +--
t/psgi_mount.t | 10 ++----
t/psgi_multipart_not.t | 7 ++---
t/psgi_scan_all.t | 5 +--
t/psgi_search.t | 8 ++---
t/psgi_text.t | 5 +--
t/psgi_v2.t | 10 ++----
t/purge.t | 6 +---
t/replace.t | 6 +---
t/search-thr-index.t | 8 ++---
t/search.t | 14 +++------
t/solver_git.t | 13 ++------
t/v1-add-remove-add.t | 6 +---
t/v1reindex.t | 6 +---
t/v2-add-remove-add.t | 6 +---
t/v2mda.t | 5 +--
t/v2mirror.t | 7 ++---
t/v2reindex.t | 6 +---
t/v2writable.t | 5 +--
t/watch_filter_rubylang.t | 7 +----
t/watch_maildir.t | 7 +----
t/watch_maildir_v2.t | 6 +---
t/www_listing.t | 8 ++---
t/xcpdb-reshard.t | 10 +++---
xt/git-http-backend.t | 8 ++---
xt/msgtime_cmp.t | 2 +-
xt/nntpd-validate.t | 8 ++---
xt/perf-nntpd.t | 1 -
54 files changed, 188 insertions(+), 295 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-12-22 22:17 5% [PATCH 0/4] support SWIG-generated Xapian binding Eric Wong
2019-12-22 22:17 7% ` [PATCH 4/4] t/search.t: update permissions check for OpenBSD Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).