* [PATCH] t/run: show unexpected output lines in logs
@ 2020-06-29 0:30 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2020-06-29 0:30 UTC (permalink / raw)
To: meta
This will help us catch warnings in new code and notice
inadvertantly skipped tests.
---
t/run.perl | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/t/run.perl b/t/run.perl
index 017ca3e82c7..b1a0d2fe154 100755
--- a/t/run.perl
+++ b/t/run.perl
@@ -61,7 +61,19 @@ our ($worker, $worker_test);
sub test_status () {
$? = 255 if $? == 0 && !$tb->is_passing;
my $status = $? ? 'not ok' : 'ok';
- print OLDOUT "$status $worker_test\n" if $log_suffix ne '';
+ chdir($cwd) or DIE "chdir($cwd): $!";
+ if ($log_suffix ne '') {
+ my $log = $worker_test;
+ $log =~ s/\.t\z/$log_suffix/;
+ if (open my $fh, '<', $log) {
+ my @not_ok = grep(!/^(?:ok |[ \t]*#)/ms, <$fh>);
+ pop @not_ok if $not_ok[-1] =~ /^[0-9]+\.\.[0-9]+$/;
+ print OLDERR map { "# $log: $_" } @not_ok;
+ } else {
+ print OLDERR "could not open: $log: $!\n";
+ }
+ print OLDOUT "$status $worker_test\n";
+ }
}
# Test::Builder or Test2::Hub may call exit() from plan(skip_all => ...)
@@ -112,7 +124,6 @@ my $start_worker = sub {
my $t = unpack('I', $buf);
run_test($todo->[$t]);
$tb->reset;
- chdir($cwd) or DIE "chdir: $!";
}
kill 'USR1', $producer if !$eof; # sets $eof in $producer
DIE join('', map { "E: $_\n" } @err) if @err;
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-06-29 0:30 7% [PATCH] t/run: show unexpected output lines in logs Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).