* [PATCH 3/4] t/nntp.t: skip if Data::Dumper is missing
2019-05-14 3:31 5% [PATCH 0/4] test loading cleanups Eric Wong
@ 2019-05-14 3:32 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-05-14 3:32 UTC (permalink / raw)
To: meta
We can revisit this, later; but Data::Dumper requires a separate
package for CentOS-7 users, at least.
---
t/nntp.t | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/t/nntp.t b/t/nntp.t
index 47b1442..c4b9737 100644
--- a/t/nntp.t
+++ b/t/nntp.t
@@ -3,9 +3,8 @@
use strict;
use warnings;
use Test::More;
-use Data::Dumper;
-foreach my $mod (qw(DBD::SQLite Search::Xapian)) {
+foreach my $mod (qw(DBD::SQLite Search::Xapian Data::Dumper)) {
eval "require $mod";
plan skip_all => "$mod missing for nntp.t" if $@;
}
@@ -15,7 +14,7 @@ use_ok 'PublicInbox::Inbox';
{
sub quote_str {
- my (undef, $s) = split(/ = /, Dumper($_[0]), 2);
+ my (undef, $s) = split(/ = /, Data::Dumper::Dumper($_[0]), 2);
$s =~ s/;\n//;
$s;
}
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/4] test loading cleanups
@ 2019-05-14 3:31 5% Eric Wong
2019-05-14 3:32 7% ` [PATCH 3/4] t/nntp.t: skip if Data::Dumper is missing Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-05-14 3:31 UTC (permalink / raw)
To: meta
We definitely don't need to check for ::DS usability anymore
now that we've bundled and forked Danga::Socket.
I also noticed Data::Dumper is a separate package on CentOS-7;
but it's a dependency of Test::Simple, already. We were also
overusing Cwd::getcwd in some areas... and may still be...
Anyways, this saves a few milliseconds here and there and
tests are now slightly faster on my slow laptop, "make check"
goes from 51s to 49s :>
Eric Wong (4):
tests: remove unnecessary loading of ::DS and Socket
t/config.t: remove Data::Dumper dependency
t/nntp.t: skip if Data::Dumper is missing
tests: get rid of unnecessary Cwd module use
t/admin.t | 1 -
t/cgi.t | 1 -
t/config.t | 12 +++++++-----
t/git-http-backend.t | 10 ++++------
t/git.t | 5 ++---
t/httpd-corner.t | 9 ++++-----
t/httpd-unix.t | 6 ++----
t/httpd.t | 7 ++-----
t/mda.t | 2 +-
t/nntp.t | 5 ++---
t/nntpd.t | 5 ++---
t/solver_git.t | 2 --
t/spamcheck_spamc.t | 1 -
t/v2mirror.t | 2 +-
t/v2writable.t | 7 ++-----
15 files changed, 29 insertions(+), 46 deletions(-)
--
EW
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-05-14 3:31 5% [PATCH 0/4] test loading cleanups Eric Wong
2019-05-14 3:32 7% ` [PATCH 3/4] t/nntp.t: skip if Data::Dumper is missing Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).