user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 1/3] t/msgtime: show date in test descriptions
  2019-11-25  5:24  6% [PATCH 0/3] msgtime: tests and wonky offsets Eric Wong
@ 2019-11-25  5:24  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-11-25  5:24 UTC (permalink / raw)
  To: meta; +Cc: Eric W. Biederman

Otherwise it's hard to figure what fails.
---
 t/msgtime.t | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/t/msgtime.t b/t/msgtime.t
index 6b396602..7bf73185 100644
--- a/t/msgtime.t
+++ b/t/msgtime.t
@@ -58,7 +58,7 @@ for (my $min = -1440; $min <= 1440; $min += 30) {
 	my $date = sprintf("Fri, 02 Oct 1993 00:00:00 %s%02d%02d",
 			   $sign, $h, $m);
 	my $result = datestamp($date);
-	is_deeply($result, [ $ts_expect, $tz_expect ]);
+	is_deeply($result, [ $ts_expect, $tz_expect ], $date);
 }
 
 # Verify that the parser sucks up the timezone and for received timestamps
@@ -74,14 +74,19 @@ for (my $min = -1440; $min <= 1440; $min += 30) {
 	}
 	my $received = sprintf('Mon, 22 Jan 2007 13:16:24 %s%02d%02d',
 			       $sign, $h, $m);
-	is_deeply(timestamp($received), [ $ts_expect, $tz_expect ]);
+	is_deeply(timestamp($received), [ $ts_expect, $tz_expect ],
+		$received);
 }
 
-is_deeply(datestamp('Wed, 13 Dec 2006 10:26:38 +1'), [1166001998, '+0100']);
-is_deeply(datestamp('Fri, 3 Feb 2006 18:11:22 -00'), [1138990282, '+0000']);
-is_deeply(datestamp('Thursday, 20 Feb 2003 01:14:34 +000'), [1045703674, '+0000']);
-is_deeply(datestamp('Fri, 28 Jun 2002 12:54:40 -700'), [1025294080, '-0700']);
-is_deeply(datestamp('Sat, 12 Jan 2002 12:52:57 -200'), [1010847177, '-0200']);
-is_deeply(datestamp('Mon, 05 Nov 2001 10:36:16 -800'), [1004985376, '-0800']);
+sub is_datestamp ($$) {
+	my ($date, $expect) = @_;
+	is_deeply(datestamp($date), $expect, $date);
+}
+is_datestamp('Wed, 13 Dec 2006 10:26:38 +1', [1166001998, '+0100']);
+is_datestamp('Fri, 3 Feb 2006 18:11:22 -00', [1138990282, '+0000']);
+is_datestamp('Thursday, 20 Feb 2003 01:14:34 +000', [1045703674, '+0000']);
+is_datestamp('Fri, 28 Jun 2002 12:54:40 -700', [1025294080, '-0700']);
+is_datestamp('Sat, 12 Jan 2002 12:52:57 -200', [1010847177, '-0200']);
+is_datestamp('Mon, 05 Nov 2001 10:36:16 -800', [1004985376, '-0800']);
 
 done_testing();

^ permalink raw reply related	[relevance 7%]

* [PATCH 0/3] msgtime: tests and wonky offsets
@ 2019-11-25  5:24  6% Eric Wong
  2019-11-25  5:24  7% ` [PATCH 1/3] t/msgtime: show date in test descriptions Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-11-25  5:24 UTC (permalink / raw)
  To: meta; +Cc: Eric W. Biederman

I've been working on making Date::Parse optional, but found
some existing bugs and improvements to test cases along the
way.

Eric Wong (3):
  t/msgtime: show date in test descriptions
  t/msgtime: add more checks for known cases
  msgtime: deal with strange minutes in TZ offsets

 lib/PublicInbox/MsgTime.pm |  4 ++++
 t/msgtime.t                | 31 ++++++++++++++++++++++---------
 2 files changed, 26 insertions(+), 9 deletions(-)


^ permalink raw reply	[relevance 6%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-11-25  5:24  6% [PATCH 0/3] msgtime: tests and wonky offsets Eric Wong
2019-11-25  5:24  7% ` [PATCH 1/3] t/msgtime: show date in test descriptions Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).