user/dev discussion of public-inbox itself
 help / color / mirror / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
			download mbox.gz: |
* [PATCH] t/msg_iter: test for X-UNKNOWN charset from Alpine
@ 2020-02-14  7:05  7% Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2020-02-14  7:05 UTC (permalink / raw)
  To: meta

A long overdue test for behavior established in 2016.

Fixes: 1b28cc7f00a866cb ("view: try assuming UTF-8 for bogus charsets")
---
 MANIFEST               |  1 +
 t/msg_iter.t           | 20 ++++++++++++++++++++
 t/x-unknown-alpine.eml | 21 +++++++++++++++++++++
 3 files changed, 42 insertions(+)
 create mode 100644 t/x-unknown-alpine.eml

diff --git a/MANIFEST b/MANIFEST
index 5acd8531..48df274e 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -299,6 +299,7 @@ t/watch_maildir.t
 t/watch_maildir_v2.t
 t/www_listing.t
 t/www_static.t
+t/x-unknown-alpine.eml
 t/xcpdb-reshard.t
 xt/git-http-backend.t
 xt/git_async_cmp.t
diff --git a/t/msg_iter.t b/t/msg_iter.t
index de9c39fa..e33bfc69 100644
--- a/t/msg_iter.t
+++ b/t/msg_iter.t
@@ -4,6 +4,7 @@ use strict;
 use warnings;
 use Test::More;
 use Email::MIME;
+use PublicInbox::Hval qw(ascii_html);
 use_ok('PublicInbox::MsgIter');
 
 {
@@ -58,5 +59,24 @@ use_ok('PublicInbox::MsgIter');
 	is(index($raw, '$$$'), -1, 'no unescaped $$$');
 }
 
+{
+	my $f = 't/x-unknown-alpine.eml';
+	my $mime = Email::MIME->new(do {
+		open my $fh, '<', $f or die "open($f): $!";
+		local $/;
+		binmode $fh;
+		<$fh>;
+	});
+	my $raw = '';
+	msg_iter($mime, sub {
+		my ($part, $level, @ex) = @{$_[0]};
+		my ($s, $err) = msg_part_text($part, 'text/plain');
+		$raw .= $s;
+	});
+	like($raw, qr!^\thttps://!ms, 'tab expanded with X-UNKNOWN');
+	like(ascii_html($raw), qr/&#8226; bullet point/s,
+		'got bullet point when X-UNKNOWN assumes UTF-8');
+}
+
 done_testing();
 1;
diff --git a/t/x-unknown-alpine.eml b/t/x-unknown-alpine.eml
new file mode 100644
index 00000000..75b0bc55
--- /dev/null
+++ b/t/x-unknown-alpine.eml
@@ -0,0 +1,21 @@
+Date:	Sat, 13 Aug 2016 12:14:15 +0200 (CEST)
+From:	Alpine User <a@example.com>
+To: <list@example.com>
+Subject: charset=X-UNKNOWN test
+Message-ID: <alpine.DEB.2.20.1608131214070.4924@example>
+User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
+MIME-Version: 1.0
+Content-Type: multipart/mixed; BOUNDARY="8323329-703494712-1471083256=:4924"
+
+  This message is in MIME format.  The first part should be readable text,
+  while the remaining parts are likely unreadable without MIME-aware tools.
+
+--8323329-703494712-1471083256=:4924
+Content-Type: text/plain; charset=X-UNKNOWN
+Content-Transfer-Encoding: QUOTED-PRINTABLE
+
+=09https://example.com/
+
+  =E2=80=A2 bullet point
+
+--8323329-703494712-1471083256=:4924--

^ permalink raw reply	[relevance 7%]

Results 1-1 of 1 | reverse
2020-02-14  7:05  7% [PATCH] t/msg_iter: test for X-UNKNOWN charset from Alpine Eric Wong

user/dev discussion of public-inbox itself

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 meta meta/ https://public-inbox.org/meta \
		meta@public-inbox.org
	public-inbox-index meta

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for the project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git