* [PATCH] t/mime: fix test to work w/o Email::MIME
@ 2020-05-10 9:41 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2020-05-10 9:41 UTC (permalink / raw)
To: meta
Although the lazy loading changes were correct, the code
was still using PublicInbox::MIME as a fixed class. Use
the `$cls' variable from the loop.
Favor ->subparts to ->parts, instead, too, since ->parts is
discouraged by the Email::MIME manpage and not implemented for
Eml.
---
t/mime.t | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/mime.t b/t/mime.t
index d17ec58e92d..46c1d8d7f5a 100644
--- a/t/mime.t
+++ b/t/mime.t
@@ -16,7 +16,7 @@ use_ok $_ for @classes;
local $SIG{__WARN__} = sub {}; # needed for old Email::Simple (used by E::M)
for my $cls (@classes) {
- my $msg = PublicInbox::MIME->new(<<'EOF');
+ my $msg = $cls->new(<<'EOF');
From: Richard Hansen <hansenr@google.com>
To: git@vger.kernel.org
Cc: Richard Hansen <hansenr@google.com>
@@ -49,7 +49,7 @@ dkTlB69771K2eXK4LcHSH/2LqX+VYa3K44vrx1ruzjXdNWzIpKBy0weFNiwnJCGofvCysM2RCSI1
EOF
- my @parts = $msg->parts;
+ my @parts = $msg->subparts;
my $exp = <<EOF;
Richard Hansen (2):
diff: document behavior of relative diff.orderFile
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-05-10 9:41 7% [PATCH] t/mime: fix test to work w/o Email::MIME Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).