* [PATCH 00/15] use RENAME_NOREPLACE on Linux 3.15+
@ 2021-10-21 21:10 7% Eric Wong
2021-10-21 21:10 5% ` [PATCH 01/15] t/lei-{auto-watch,export-kw}: extra diagnostics on failure Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-10-21 21:10 UTC (permalink / raw)
To: meta
What started off as a trivial, "something-to-do-before-bedtime"
change several days ago (15/15) ended up forcing me to fix
various hard-to-reproduce race conditions around Maildirs.
Eventually, `schedtool -a 0x1 -e ...' helped me reproduce
some races more easily (but still not with 100% reliability).
t/lei-{watch,auto-watch,export-kw}.t should all be more
reliable, now.
There's also several other minor fixes I found along the way...
Eric Wong (15):
t/lei-{auto-watch,export-kw}: extra diagnostics on failure
t/lei-import-maildir: rename fix (SR -> RS)
t/lei-p2q: extra diagnostics
lei/store: check for any unexpected process death
lei note-event: drop unnecessary eval guard
lei note-event: wq_io_do => wq_do
lei_search: try harder to associate "lei index"-ed messages
watch: check for {quit} before IDLE
watch: remove redundant signal mask manipulation
doc: lei-overview: add CAVEATS section
lei note-event: clear_src on ENOENT
dir_idle: treat IN_MOVED_FROM as a gone event
lei: no Perl FileHandle for `undef' w/ ECONNRESET
lei_mail_sync: mv_src: use transaction, check UNIQUE
lei: use RENAME_NOREPLACE on Linux 3.15+
Documentation/lei-overview.pod | 5 ++++
MANIFEST | 1 +
devel/syscall-list | 8 +++++-
lib/PublicInbox/DirIdle.pm | 3 +-
lib/PublicInbox/FakeInotify.pm | 3 ++
lib/PublicInbox/LEI.pm | 3 +-
lib/PublicInbox/LeiExportKw.pm | 19 ++++---------
lib/PublicInbox/LeiMailSync.pm | 8 ++++--
lib/PublicInbox/LeiNoteEvent.pm | 13 +++++----
lib/PublicInbox/LeiSearch.pm | 13 ++++++++-
lib/PublicInbox/LeiStore.pm | 16 +++++++----
lib/PublicInbox/LeiToMail.pm | 7 ++---
lib/PublicInbox/Syscall.pm | 49 +++++++++++++++++++++++++++++++--
lib/PublicInbox/Watch.pm | 13 +++------
t/lei-auto-watch.t | 3 +-
t/lei-export-kw.t | 39 ++++++++++++++++++--------
t/lei-import-maildir.t | 2 +-
t/lei-p2q.t | 2 +-
t/rename_noreplace.t | 26 +++++++++++++++++
19 files changed, 173 insertions(+), 60 deletions(-)
create mode 100644 t/rename_noreplace.t
^ permalink raw reply [relevance 7%]
* [PATCH 01/15] t/lei-{auto-watch,export-kw}: extra diagnostics on failure
2021-10-21 21:10 7% [PATCH 00/15] use RENAME_NOREPLACE on Linux 3.15+ Eric Wong
@ 2021-10-21 21:10 5% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-10-21 21:10 UTC (permalink / raw)
To: meta
Maybe these will help track down some failures and make
diagnosing bugs easier. "lei export-kw" should also become
optional, even, so allow disabling it easily in the test.
---
t/lei-auto-watch.t | 3 ++-
t/lei-export-kw.t | 39 ++++++++++++++++++++++++++++-----------
2 files changed, 30 insertions(+), 12 deletions(-)
diff --git a/t/lei-auto-watch.t b/t/lei-auto-watch.t
index e5e132eb3bfd..d5661ae5d618 100644
--- a/t/lei-auto-watch.t
+++ b/t/lei-auto-watch.t
@@ -41,7 +41,8 @@ test_lei(sub {
$ins = json_utf8->decode($lei_out);
$exp = { "maildir:$x" => [ map { basename($_) } glob("$x/*/*") ],
"maildir:$y" => [ map { basename($_) } glob("$y/*/*") ] };
- is_deeply($ins->{'mail-sync'}, $exp, 'mail_sync matches FS');
+ is_deeply($ins->{'mail-sync'}, $exp, 'mail_sync matches FS') or
+ diag explain($ins);
});
done_testing;
diff --git a/t/lei-export-kw.t b/t/lei-export-kw.t
index 1fe940bb6d89..55730e87c050 100644
--- a/t/lei-export-kw.t
+++ b/t/lei-export-kw.t
@@ -7,28 +7,45 @@ use File::Path qw(make_path);
require_mods(qw(lei -imapd Mail::IMAPClient));
my ($tmpdir, $for_destroy) = tmpdir;
my $expect = eml_load('t/data/0001.patch');
+my $do_export_kw = 1;
+my $wait_for = sub {
+ my ($f) = @_;
+ lei_ok qw(export-kw --all=local) if $do_export_kw;
+ my $x = $f;
+ $x =~ s!\Q$tmpdir\E/!\$TMPDIR/!;
+ for (0..10) {
+ last if -f $f;
+ diag "tick #$_ $x";
+ tick(0.1);
+ }
+ ok(-f $f, "$x exists") or xbail;
+};
+
test_lei({ tmpdir => $tmpdir }, sub {
my $home = $ENV{HOME};
my $md = "$home/md";
+ my $f;
make_path("$md/new", "$md/cur", "$md/tmp");
cp('t/data/0001.patch', "$md/new/y") or xbail "cp $md $!";
cp('t/data/message_embed.eml', "$md/cur/x:2,S") or xbail "cp $md $!";
- lei_ok qw(index -q), $md;
+ lei_ok qw(index), $md;
lei_ok qw(tag t/data/0001.patch +kw:seen);
- lei_ok qw(export-kw --all=local);
- ok(!-e "$md/new/y", 'original gone');
- is_deeply(eml_load("$md/cur/y:2,S"), $expect,
- "`seen' kw exported");
+ $wait_for->($f = "$md/cur/y:2,S");
+ ok(!-e "$md/new/y", 'original gone') or
+ diag explain([glob("$md/*/*")]);
+ is_deeply(eml_load($f), $expect, "`seen' kw exported");
lei_ok qw(tag t/data/0001.patch +kw:answered);
- lei_ok qw(export-kw --all=local);
- ok(!-e "$md/cur/y:2,S", 'seen-only file gone');
- is_deeply(eml_load("$md/cur/y:2,RS"), $expect, "`R' added");
+ $wait_for->($f = "$md/cur/y:2,RS");
+ ok(!-e "$md/cur/y:2,S", 'seen-only file gone') or
+ diag explain([glob("$md/*/*")]);
+ is_deeply(eml_load($f), $expect, "`R' added");
lei_ok qw(tag t/data/0001.patch -kw:answered -kw:seen);
- lei_ok qw(export-kw --mode=set --all=local);
- ok(!-e "$md/cur/y:2,RS", 'seen+answered file gone');
- is_deeply(eml_load("$md/cur/y:2,"), $expect, 'no keywords left');
+ $wait_for->($f = "$md/cur/y:2,");
+ ok(!-e "$md/cur/y:2,RS", 'seen+answered file gone') or
+ diag explain([glob("$md/*/*")]);
+ is_deeply(eml_load($f), $expect, 'no keywords left');
});
done_testing;
^ permalink raw reply related [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-10-21 21:10 7% [PATCH 00/15] use RENAME_NOREPLACE on Linux 3.15+ Eric Wong
2021-10-21 21:10 5% ` [PATCH 01/15] t/lei-{auto-watch,export-kw}: extra diagnostics on failure Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).