user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH] t/config_limiter: fix check for identical Git object
@ 2016-07-30 23:33  7% Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2016-07-30 23:33 UTC (permalink / raw)
  To: meta

If we completely undef an object, it is likely possible
to have the same scalar address as the original object
even if they are different.  So keep the same object
around and only force creation of the same reference.
Tested on Perl 5.14.2 on Debian 7.x wheezy.
---
 t/config_limiter.t | 1 -
 1 file changed, 1 deletion(-)

diff --git a/t/config_limiter.t b/t/config_limiter.t
index bfea151..3c7ec55 100644
--- a/t/config_limiter.t
+++ b/t/config_limiter.t
@@ -17,7 +17,6 @@ my $cfgpfx = "publicinbox.test";
 	my $lim = $git->{-httpbackend_limiter};
 	ok($lim, 'Limiter exists');
 	is($lim->{max}, 12, 'limiter has expected slots');
-	$git = undef;
 	$ibx->{git} = undef;
 	$git = $ibx->git;
 	isnt($old, "$git", 'got new Git object');
-- 
EW


^ permalink raw reply related	[relevance 7%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-07-30 23:33  7% [PATCH] t/config_limiter: fix check for identical Git object Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).