* [PATCH] switch to sysseek + sysread for serving static files
@ 2020-01-25 20:57 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2020-01-25 20:57 UTC (permalink / raw)
To: meta
The "perlio" layer doesn't do read(2) syscalls over 8192 bytes
at the moment, and binmode($fh, ':unix') leaks[1]. So use
sysseek and sysread for now, since I can't see retaining
compatibility with PerlIO::scalar being worth the trouble.
[1] http://nntp.perl.org/group/perl.perl5.porters/256918
---
lib/PublicInbox/DS.pm | 4 ++--
lib/PublicInbox/WwwStatic.pm | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm
index c76a5038..4d685131 100644
--- a/lib/PublicInbox/DS.pm
+++ b/lib/PublicInbox/DS.pm
@@ -395,10 +395,10 @@ sub close {
sub send_tmpio ($$) {
my ($sock, $tmpio) = @_;
- seek($tmpio->[0], $tmpio->[1], SEEK_SET) or return;
+ sysseek($tmpio->[0], $tmpio->[1], SEEK_SET) or return;
my $n = $tmpio->[2] // 65536;
$n = 65536 if $n > 65536;
- defined(my $to_write = read($tmpio->[0], my $buf, $n)) or return;
+ defined(my $to_write = sysread($tmpio->[0], my $buf, $n)) or return;
my $written = 0;
while ($to_write > 0) {
if (defined(my $w = syswrite($sock, $buf, $to_write, $written))) {
diff --git a/lib/PublicInbox/WwwStatic.pm b/lib/PublicInbox/WwwStatic.pm
index 60a71d8d..547b75bb 100644
--- a/lib/PublicInbox/WwwStatic.pm
+++ b/lib/PublicInbox/WwwStatic.pm
@@ -176,9 +176,9 @@ sub getline {
my $len = $self->{len} or return; # undef, tells server we're done
my $n = 8192;
$n = $len if $len < $n;
- seek($self->{in}, $self->{off}, SEEK_SET) or
- die "seek ($self->{path}): $!";
- my $r = read($self->{in}, my $buf, $n);
+ sysseek($self->{in}, $self->{off}, SEEK_SET) or
+ die "sysseek ($self->{path}): $!";
+ my $r = sysread($self->{in}, my $buf, $n);
if (defined $r && $r > 0) { # success!
$self->{len} = $len - $r;
$self->{off} += $r;
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-01-25 20:57 7% [PATCH] switch to sysseek + sysread for serving static files Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).