* [PATCH 3/5] spawn: remove stray variable $ndc_err
@ 2023-08-28 10:42 7% ` Štěpán Němec
0 siblings, 0 replies; 1+ results
From: Štěpán Němec @ 2023-08-28 10:42 UTC (permalink / raw)
To: meta
Code that could be setting it was removed in 14fa0abdcc7b.
Likewise for the double assignment to $err.
Fixes: 14fa0abdcc7b ("rewrite Linux nodatacow use in pure Perl w/o system")
---
lib/PublicInbox/Spawn.pm | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm
index 878843a60a8d..6e33c712d8d2 100644
--- a/lib/PublicInbox/Spawn.pm
+++ b/lib/PublicInbox/Spawn.pm
@@ -293,15 +293,12 @@ ALL_LIBC
use Inline C => $all_libc, BUILD_NOISY => 1;
EOM
my $err = $@;
- my $ndc_err = '';
- $err = $@;
open(STDERR, '>&', $olderr) or warn "restore stderr: $!";
open(STDOUT, '>&', $oldout) or warn "restore stdout: $!";
if ($err) {
seek($fh, 0, SEEK_SET);
my @msg = <$fh>;
- warn "Inline::C build failed:\n",
- $ndc_err, $err, "\n", @msg;
+ warn "Inline::C build failed:\n", $err, "\n", @msg;
$all_libc = undef;
}
}
--
2.42.0
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-08-28 10:42 [PATCH 1/5] ci/profiles.sh: fix case matching logic Štěpán Němec
2023-08-28 10:42 7% ` [PATCH 3/5] spawn: remove stray variable $ndc_err Štěpán Němec
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).