user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH] solvergit: don't confuse Xapian with ".." in filenames
@ 2019-01-30 10:35  7% Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2019-01-30 10:35 UTC (permalink / raw)
  To: meta

Xapian will interpret ".." as ranges, even quoted phrases.
So break up words on ".." since punctuation (AFAIK) is not
searchable, anyways.
---
 lib/PublicInbox/SolverGit.pm | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/SolverGit.pm b/lib/PublicInbox/SolverGit.pm
index 59d2c93..c502526 100644
--- a/lib/PublicInbox/SolverGit.pm
+++ b/lib/PublicInbox/SolverGit.pm
@@ -170,6 +170,13 @@ sub extract_diff ($$$$$) {
 
 sub path_searchable ($) { defined($_[0]) && $_[0] =~ m!\A[\w/\. \-]+\z! }
 
+# ".." appears in path names, which confuses Xapian into treating
+# it as a range query.  So we split on ".." since Xapian breaks
+# on punctuation anyways:
+sub filename_query ($) {
+	join('', map { qq( dfn:"$_") } split(/\.\./, $_[0]));
+}
+
 sub find_extract_diff ($$$) {
 	my ($self, $ibx, $want) = @_;
 	my $srch = $ibx->search or return;
@@ -187,11 +194,11 @@ sub find_extract_diff ($$$) {
 
 	my $path_b = $want->{path_b};
 	if (path_searchable($path_b)) {
-		$q .= qq{ dfn:"$path_b"};
+		$q .= filename_query($path_b);
 
 		my $path_a = $want->{path_a};
 		if (path_searchable($path_a) && $path_a ne $path_b) {
-			$q .= qq{ dfn:"$path_a"};
+			$q .= filename_query($path_a);
 		}
 	}
 
-- 
EW


^ permalink raw reply related	[relevance 7%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-01-30 10:35  7% [PATCH] solvergit: don't confuse Xapian with ".." in filenames Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).