* [PATCH 2/2] searchmsg: do not memoize {date} field
@ 2016-12-17 11:53 7% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2016-12-17 11:53 UTC (permalink / raw)
To: meta
We only generate the ->date once in NNTP, so creating
the hash entry is a waste.
---
lib/PublicInbox/SearchMsg.pm | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/PublicInbox/SearchMsg.pm b/lib/PublicInbox/SearchMsg.pm
index 57fec16..9f3e27f 100644
--- a/lib/PublicInbox/SearchMsg.pm
+++ b/lib/PublicInbox/SearchMsg.pm
@@ -77,13 +77,10 @@ my @MoY = qw(Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec);
sub date ($) {
my ($self) = @_;
- my $date = __hdr($self, 'date');
- return $date if defined $date;
my $ts = $self->{ts};
return unless defined $ts;
my ($sec, $min, $hour, $mday, $mon, $year, $wday) = gmtime($ts);
- $self->{date} = "$DoW[$wday], ".
- sprintf("%02d $MoY[$mon] %04d %02d:%02d:%02d +0000",
+ "$DoW[$wday], " . sprintf("%02d $MoY[$mon] %04d %02d:%02d:%02d +0000",
$mday, $year+1900, $hour, $min, $sec);
}
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-12-17 11:53 [PATCH 0/2] searchmsg: ->date correctness Eric Wong
2016-12-17 11:53 7% ` [PATCH 2/2] searchmsg: do not memoize {date} field Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).