user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH] searchmsg: allow lines (and bytes) to be zero
@ 2020-03-07 10:57  7% Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2020-03-07 10:57 UTC (permalink / raw)
  To: meta

We will occasionally see legit messages with zero lines,
be sure we index that count for NNTP clients.

I'm not sure about bytes being zero (aside from purged
messages), but we should've dealt with that earlier up
the stack.
---
 lib/PublicInbox/SearchMsg.pm | 4 ++--
 t/v2mirror.t                 | 5 +++++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/SearchMsg.pm b/lib/PublicInbox/SearchMsg.pm
index 42384936..84fe4802 100644
--- a/lib/PublicInbox/SearchMsg.pm
+++ b/lib/PublicInbox/SearchMsg.pm
@@ -42,8 +42,8 @@ sub to_doc_data {
 		$self->cc,
 		$oid,
 		$mid0,
-		$self->{bytes} || '',
-		$self->{lines} || ''
+		$self->{bytes} // '',
+		$self->{lines} // ''
 	);
 }
 
diff --git a/t/v2mirror.t b/t/v2mirror.t
index dc930d90..2e23e763 100644
--- a/t/v2mirror.t
+++ b/t/v2mirror.t
@@ -55,6 +55,11 @@ for my $i (1..9) {
 my $epoch_max = $v2w->{epoch_max};
 ok($epoch_max > 0, "multiple epochs");
 $v2w->done;
+{
+	my $smsg = $ibx->over->get_art(1);
+	like($smsg->{lines}, qr/\A[0-9]+\z/, 'lines is a digit');
+	like($smsg->{bytes}, qr/\A[0-9]+\z/, 'bytes is a digit');
+}
 $ibx->cleanup;
 
 my $sock = tcp_server();

^ permalink raw reply	[relevance 7%]

Results 1-1 of 1 | reverse | sort options + mbox downloads above
-- links below jump to the message on this page --
2020-03-07 10:57  7% [PATCH] searchmsg: allow lines (and bytes) to be zero Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).