user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 2/3] searchidx: fix obvious typo
  2019-05-27 18:45  6% ` [PATCH 0/3] fix --reindex skipping NNTP article numbers Eric Wong
@ 2019-05-27 18:45  7%   ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-05-27 18:45 UTC (permalink / raw)
  To: meta

We can't pass an empty string to `git merge-base --is-ancestor'
AFAIK, this did NOT present issues in the current test suite.
---
 lib/PublicInbox/SearchIdx.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index 9c29106..b963805 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -694,7 +694,7 @@ sub _last_x_commit {
 		$lx = $lm;
 	}
 	# Use last_commit from msgmap if it is older or unset
-	if (!$lm || ($lx && $lx && is_ancestor($self->{git}, $lm, $lx))) {
+	if (!$lm || ($lx && $lm && is_ancestor($self->{git}, $lm, $lx))) {
 		$lx = $lm;
 	}
 	$lx;
-- 
EW


^ permalink raw reply	[relevance 7%]

* [PATCH 0/3] fix --reindex skipping NNTP article numbers
  @ 2019-05-27 18:45  6% ` Eric Wong
  2019-05-27 18:45  7%   ` [PATCH 2/3] searchidx: fix obvious typo Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-05-27 18:45 UTC (permalink / raw)
  To: meta

I was working on v2 cleanups and progress-reporting,
and speeding up no-op 'public-inbox-index' invocations when
I noticed --reindex showing higher-than-expected NNTP
article numbers with the verbose output I'm working on.

There's some (apparently) inconsequential typo fixes, too.
I think the v1 --reindex code is alright, after all, but
maybe I haven't been paying enough attention to it...

Also, I've noticed the v1 indexing code works around a Xapian
v1.2.20..v1.2.24 bug wrt OFD locks which the newer v2 code
doesn't (since v2 was developed mainly on Xapian 1.4.3+).
Not sure who uses Xapian 1.2, still; but it might still be
worth fixing for folks on older systems.

Eric Wong (3):
  t/v1reindex.t: fix typo in setting `indexlevel'
  searchidx: fix obvious typo
  v2: fix reindex skipping NNTP article numbers

 lib/PublicInbox/SearchIdx.pm  |  2 +-
 lib/PublicInbox/V2Writable.pm | 25 ++++++++++++++++++++++++-
 t/indexlevels-mirror.t        | 25 +++++++++++++++++++++++++
 t/v1reindex.t                 |  2 +-
 4 files changed, 51 insertions(+), 3 deletions(-)

-- 
EW


^ permalink raw reply	[relevance 6%]

Results 1-2 of 2 | reverse | sort options + mbox downloads above
-- links below jump to the message on this page --
2019-05-25 19:57     --reindex buggy wrt NNTP numbers, fixes coming Eric Wong
2019-05-27 18:45  6% ` [PATCH 0/3] fix --reindex skipping NNTP article numbers Eric Wong
2019-05-27 18:45  7%   ` [PATCH 2/3] searchidx: fix obvious typo Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).