user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH] searchidx: fix Xapian version comparison
@ 2024-05-06 23:19  7% Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2024-05-06 23:19 UTC (permalink / raw)
  To: meta

We must use Perl v-strings consistently on both sides of the
comparison.  Fortunately, this was merely a no-op and didn't
cause any data integrity problems (aside from increased wear on
the storage device).

Fixes: c25c66af0a8a (searchidx: use vstring to improve readability, 2023-04-07)
---
 lib/PublicInbox/SearchIdx.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index 1cbf6d23..d3a7a0c0 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -119,7 +119,7 @@ sub load_xapian_writable () {
 	my $ver = eval 'v'.join('.', eval($xap.'::major_version()'),
 				eval($xap.'::minor_version()'),
 				eval($xap.'::revision()'));
-	if ($ver ge 1.4) { # new flags in Xapian 1.4
+	if ($ver ge v1.4) { # new flags in Xapian 1.4
 		$DB_NO_SYNC = 0x4;
 		$DB_DANGEROUS = 0x10;
 	}

^ permalink raw reply related	[relevance 7%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2024-05-06 23:19  7% [PATCH] searchidx: fix Xapian version comparison Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).