user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH] searchidx: croak for Xapian DB open failure
@ 2020-08-23 21:00  7% Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2020-08-23 21:00 UTC (permalink / raw)
  To: meta

croak() can give more context on the failure, and setting
`PERL5OPT=-MCarp=verbose' can force a stacktrace.
---
 lib/PublicInbox/SearchIdx.pm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index ade55756..3f2da6ab 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -137,9 +137,7 @@ sub idx_acquire {
 	return unless defined $flag;
 	$flag |= $DB_NO_SYNC if $self->{ibx}->{-no_fsync};
 	my $xdb = eval { ($X->{WritableDatabase})->new($dir, $flag) };
-	if ($@) {
-		die "Failed opening $dir: ", $@;
-	}
+	croak "Failed opening $dir: $@" if $@;
 	$self->{xdb} = $xdb;
 }
 

^ permalink raw reply related	[relevance 7%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-08-23 21:00  7% [PATCH] searchidx: croak for Xapian DB open failure Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).