* [PATCH 07/11] search: remove {over_ro} field
2020-09-02 11:04 6% [PATCH 00/11] cleanups, mostly indexing related Eric Wong
@ 2020-09-02 11:04 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-09-02 11:04 UTC (permalink / raw)
To: meta
Only inbox accesses the read-only {over}, now, instead of going
through ->search. This simplifies our object graph and avoids
potentially redundant FDs and DB handles pointing to the same
over.sqlite3 file.
---
lib/PublicInbox/Inbox.pm | 11 +++++------
lib/PublicInbox/Search.pm | 2 --
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 4005954e..b0894a7d 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -206,14 +206,13 @@ EOF
};
}
-sub over ($) {
- my ($self) = @_;
- my $srch = search($self, 1) or return;
- $self->{over} //= eval {
- my $over = $srch->{over_ro};
+sub over {
+ $_[0]->{over} //= eval {
+ my $srch = search($_[0], 1) or return;
+ my $over = PublicInbox::Over->new("$srch->{xpfx}/over.sqlite3");
$over->dbh; # may fail
$over;
- }
+ };
}
sub try_cat {
diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index cfa942b2..b07f4ea6 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -265,8 +265,6 @@ sub new {
ibx_ver => $ibx->version,
}, $class;
xpfx_init($self);
- my $dir = xdir($self, 1);
- $self->{over_ro} = PublicInbox::Over->new("$dir/over.sqlite3");
$self;
}
^ permalink raw reply related [relevance 7%]
* [PATCH 00/11] cleanups, mostly indexing related
@ 2020-09-02 11:04 6% Eric Wong
2020-09-02 11:04 7% ` [PATCH 07/11] search: remove {over_ro} field Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-09-02 11:04 UTC (permalink / raw)
To: meta
Some cleanups ahead of detached index support.
Found some dead code, too.
Eric Wong (11):
msgmap: note how we use ->created_at
disambiguate OverIdx and Over by field name
use more idiomatic internal API for ->over access
search: remove special case for blank query
tests: add "use strict" and declare v5.10.1 compatibility
search: replace ->query with ->mset
search: remove {over_ro} field
imap: drop old, pre-Parse::RecDescent search parser
wwwaltid: drop unused sqlite3_missing function
overidx: document column uses
v2writable: reuse read-only shard counting code
lib/PublicInbox/ExtMsg.pm | 4 +-
lib/PublicInbox/IMAP.pm | 63 +----------------
lib/PublicInbox/Inbox.pm | 11 ++-
lib/PublicInbox/Mbox.pm | 6 +-
lib/PublicInbox/Msgmap.pm | 1 +
lib/PublicInbox/OverIdx.pm | 18 ++---
lib/PublicInbox/Search.pm | 32 ++++-----
lib/PublicInbox/SearchIdx.pm | 32 ++++-----
lib/PublicInbox/SearchView.pm | 3 +-
lib/PublicInbox/SolverGit.pm | 5 +-
lib/PublicInbox/V2Writable.pm | 59 ++++++----------
lib/PublicInbox/WwwAltId.pm | 16 +----
scripts/dupe-finder | 3 +-
t/altid.t | 8 +--
t/altid_v2.t | 7 +-
t/index-git-times.t | 17 +++--
t/indexlevels-mirror.t | 8 +--
t/mda_filter_rubylang.t | 6 +-
t/replace.t | 8 +--
t/search-thr-index.t | 8 +--
t/search.t | 126 +++++++++++++++++-----------------
t/v1reindex.t | 4 +-
t/v2mda.t | 16 +++--
t/v2mirror.t | 24 +++----
t/v2reindex.t | 9 +--
t/v2writable.t | 14 ++--
t/watch_filter_rubylang.t | 12 ++--
t/watch_maildir_v2.t | 30 ++++----
t/xcpdb-reshard.t | 3 +-
xt/eml_check_limits.t | 2 +
xt/perf-threading.t | 2 +-
31 files changed, 232 insertions(+), 325 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-09-02 11:04 6% [PATCH 00/11] cleanups, mostly indexing related Eric Wong
2020-09-02 11:04 7% ` [PATCH 07/11] search: remove {over_ro} field Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).