* [PATCH 07/10] search: fix compatibility with Debian wheezy
2016-09-09 0:01 6% [PATCH 0/10] search: more mairix prefix compatibility Eric Wong
@ 2016-09-09 0:01 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-09-09 0:01 UTC (permalink / raw)
To: meta
Specifying the "d:" field only worked for
NumberValueRangeProcessor in older versions of Xapian, such
as the one in Debian wheezy (libsearch-xapian-perl=1.2.10.0-1)
This slipped through since I rarely use wheezy, anymore, and
perhaps nobody else does, either. Perhaps wheezy support may be
dropped, soon.
Unfortunately, this requires a schema version bump.
---
lib/PublicInbox/Search.pm | 5 +++--
lib/PublicInbox/SearchIdx.pm | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index c8e297f..ceee39a 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -38,7 +38,8 @@ use constant {
# 9 - disable Message-ID compression (SHA-1)
# 10 - optimize doc for NNTP overviews
# 11 - merge threads when vivifying ghosts
- SCHEMA_VERSION => 11,
+ # 12 - change YYYYMMDD value column to numeric
+ SCHEMA_VERSION => 12,
# n.b. FLAG_PURE_NOT is expensive not suitable for a public website
# as it could become a denial-of-service vector
@@ -221,7 +222,7 @@ sub qp {
$qp->set_stemmer($self->stemmer);
$qp->set_stemming_strategy(STEM_SOME);
$qp->add_valuerangeprocessor(
- Search::Xapian::StringValueRangeProcessor->new(YYYYMMDD, 'd:'));
+ Search::Xapian::NumberValueRangeProcessor->new(YYYYMMDD, 'd:'));
while (my ($name, $prefix) = each %bool_pfx_external) {
$qp->add_boolean_prefix($name, $prefix);
diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index 0e499ad..86be9ed 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -117,7 +117,7 @@ sub add_values ($$$) {
$smsg->{mime}->body_raw =~ tr!\n!\n!);
my $yyyymmdd = strftime('%Y%m%d', gmtime($ts));
- $doc->add_value(&PublicInbox::Search::YYYYMMDD, $yyyymmdd);
+ add_val($doc, PublicInbox::Search::YYYYMMDD, $yyyymmdd);
}
sub index_users ($$) {
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/10] search: more mairix prefix compatibility
@ 2016-09-09 0:01 6% Eric Wong
2016-09-09 0:01 7% ` [PATCH 07/10] search: fix compatibility with Debian wheezy Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-09-09 0:01 UTC (permalink / raw)
To: meta
This brings us closer to the behavior of mairix(1) for search
by supporting n:, t:, c:, f:, tc:, tcf:, n:, b:, and bs:
prefixes as documented in the mairix(1) manpage.
We also introduce the use of q: and nq: prefixes for quoted and
non-quoted text, respectively.
There is a schema version change in [PATCH 7/10] to maintain
compatibility with Debian 7.x wheezy installs. The in-place
reindexing would've been expensive anyways, so perhaps the
schema bump is a good idea, anyways, as creating a fresh index
should be faster than --reindex.
Eric Wong (10):
search: allow searching user fields (To/Cc/From)
search: drop longer subject: prefix for search
search: more granular message body searching
search: fix space regressions from recent changes
search: match quote detection behavior of view
search: increase term positions for each quoted hunk
search: fix compatibility with Debian wheezy
search: avoid mindlessly calling body_set
search: match the behavior of WWW for indexing text
search: index attachment filenames
lib/PublicInbox/Search.pm | 32 +++++++++---
lib/PublicInbox/SearchIdx.pm | 104 ++++++++++++++++++++++++-------------
t/search.t | 120 ++++++++++++++++++++++++++++++++++++++++---
3 files changed, 206 insertions(+), 50 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-09-09 0:01 6% [PATCH 0/10] search: more mairix prefix compatibility Eric Wong
2016-09-09 0:01 7% ` [PATCH 07/10] search: fix compatibility with Debian wheezy Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).