* [PATCH 3/9] search: delete QueryParser along with DB handle
2021-10-12 11:46 4% [PATCH 0/9] various read-only daemon and WWW things Eric Wong
@ 2021-10-12 11:46 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-10-12 11:46 UTC (permalink / raw)
To: meta
Xapian::QueryParser is attached to the Xapian::Database,
so holding onto the QueryParser was preventing us from
releasing DB handles if a query was performed.
---
lib/PublicInbox/Search.pm | 2 +-
t/extsearch.t | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index 17e202e1..dd6d3710 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -253,7 +253,7 @@ sub cleanup_shards {
my $nr = grep(/\A[0-9]+\z/, readdir($dh)) or
return warn("$xpfx has no shards\n"); # true
return reopen($self) if $nr == ($self->{nshard} // -1);
- delete($self->{xdb});
+ delete @$self{qw(xdb qp)};
undef;
}
diff --git a/t/extsearch.t b/t/extsearch.t
index 1b6235ba..8190de17 100644
--- a/t/extsearch.t
+++ b/t/extsearch.t
@@ -176,7 +176,7 @@ if ('inbox edited') {
is($mset->size, 1, 'new message found');
$mset = $es->mset('b:"test message"');
is($mset->size, 1, 'old message found');
- delete @$es{qw(git over xdb)}; # fork preparation
+ delete @$es{qw(git over xdb qp)}; # fork preparation
my $pi_cfg = PublicInbox::Config->new;
$pi_cfg->fill_all;
^ permalink raw reply related [relevance 7%]
* [PATCH 0/9] various read-only daemon and WWW things
@ 2021-10-12 11:46 4% Eric Wong
2021-10-12 11:46 7% ` [PATCH 3/9] search: delete QueryParser along with DB handle Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-10-12 11:46 UTC (permalink / raw)
To: meta
Read-only daemons close idle descriptors much more aggressively,
now. This should reduce userspace and kernel memory use during
non-peak times with negligible slowdown under heavy load.
Some fairly big msgmap-related cleanups and WWW now exposes
mm->created_at AKA UIDVALIDITY as the Last-Modified time
of the _/text/config/raw endpoint. (see 9/9)
Eric Wong (9):
daemon: use v5.10.1, disable local warnings
daemon: quiet down Eml-related warnings
search: delete QueryParser along with DB handle
nntp: use defined-OR from Perl 5.10 for msgid check
msgmap: use DBI->prepare_cached
msgmap: share most of check_inodes w/ over
daemon: unconditionally close Xapian shards on cleanup
msgmap: ->new_file to supports $ibx arg, drop ->new
www: _/text/config/raw Last-Modified: is mm->created_at
lib/PublicInbox/Daemon.pm | 8 ++-
lib/PublicInbox/Inbox.pm | 18 +++---
lib/PublicInbox/InboxWritable.pm | 2 +-
lib/PublicInbox/LeiMirror.pm | 13 ++--
lib/PublicInbox/Msgmap.pm | 102 +++++++++++++------------------
lib/PublicInbox/NNTP.pm | 6 +-
lib/PublicInbox/Search.pm | 14 -----
lib/PublicInbox/SearchIdx.pm | 3 +-
lib/PublicInbox/V2Writable.pm | 4 +-
lib/PublicInbox/WwwText.pm | 3 +
t/altid.t | 4 +-
t/altid_v2.t | 4 +-
t/extsearch.t | 10 +--
t/filter_rubylang.t | 2 +-
t/init.t | 3 +-
t/lei-mirror.t | 31 +++++++++-
t/msgmap.t | 5 +-
t/psgi_v2.t | 10 ++-
18 files changed, 120 insertions(+), 122 deletions(-)
^ permalink raw reply [relevance 4%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-10-12 11:46 4% [PATCH 0/9] various read-only daemon and WWW things Eric Wong
2021-10-12 11:46 7% ` [PATCH 3/9] search: delete QueryParser along with DB handle Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).